1630998 - Unused CSS and SVG wasn’t cleaned after 489190:77db683dcaf1

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[ariasuni]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

CSS wasn’t updated to reflect that the hbox#protections-popup-trackersView-strict-info was removed.

The unused CSS refers to a svg icon that’s used nowhere else:
https://searchfox.org/mozilla-central/source/browser/themes/shared/controlcenter/info.svg

Comment 1

[ariasuni]

Relevant commit: https://hg.mozilla.org/mozilla-central/rev/77db683dcaf15439cc8915bda331fb0ab27a200a
CSS file: https://hg.mozilla.org/mozilla-central/file/tip/browser/themes/shared/controlcenter/panel.inc.css

Comment 2

[Firefox Bug Husbandry Bot]

Resetting severity to default of --.

Comment 3

[Marcela (Please NI request to Brindusa Tot)]

Hi!
This sounds like an enhancement. I will set Product and Component to have a starting point for this. If this is not the right component please feel free to route this ticket to the corresponding team, thanks!

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Thanks for filing ariasuni!

Nihant, should we clean this up / make this a good-first-bug or such?

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Yup, that's a good idea.

Comment 6

[Jayati Shrivastava]

Hello, May I submit a patch for this?

Comment 7

[Jayati Shrivastava]

Attachment: Bug 1630998 - Remove unused CSS and SVG related to protections-popup-trackersView-strict-info. r=nhnt11

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b44919091c7
Remove unused CSS and SVG related to protections-popup-trackersView-strict-info. r=nhnt11

Comment 9

[Daniel Varga [:dvarga]]

Backed out changeset 2b44919091c7 (Bug 1630998) for causing build bustages

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=2b44919091c73b95dc0f21559072c8509346c6fd

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299570191&repo=autoland&lineNumber=61784

Backout log: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=dc41492033491f409344d26684c2de16db767900

[task 2020-04-27T14:48:57.347Z] 14:48:57     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/browser/themes/linux'
[task 2020-04-27T14:48:57.347Z] 14:48:57     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/init_py3/bin/python -m mozbuild.action.jar_maker   -d ../../../dist/bin/browser -t /builds/worker/checkouts/gecko -f symlink  --relativesrcdir=browser/themes/linux -c /builds/worker/checkouts/gecko/browser/themes/linux/en-US -DNDEBUG=1 -DTRIMMED=1 -DMENUBAR_CAN_AUTOHIDE=1 -DACCESSIBILITY=1 -DATK_MAJOR_VERSION=2 -DATK_MINOR_VERSION=8 -DATK_REV_VERSION=0 -DBROWSER_CHROME_URL=chrome://browser/content/browser.xhtml -DBROWSER_CHROME_URL_QUOTED='"chrome://browser/content/browser.xhtml"' -DBUILD_CTYPES=1 -DCROSS_COMPILE='' -DEARLY_BETA_OR_EARLIER=1 -DENABLE_REMOTE_AGENT=1 -DENABLE_SHARED_MEMORY=1 -DENABLE_SYSTEM_EXTENSION_DIRS=1 -DENABLE_TESTS=1 -DENABLE_WASM_BIGINT=1 -DENABLE_WASM_BULKMEM_OPS=1 -DENABLE_WASM_CRANELIFT=1 -DENABLE_WASM_GC=1 -DENABLE_WASM_MULTI_VALUE=1 -DENABLE_WASM_REFTYPES=1 -DFORCE_PR_LOG=1 -DFUNCPROTO=15 -DGDK_VERSION_MAX_ALLOWED=GDK_VERSION_3_4 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32 -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DGL_PROVIDER_EGL=1 -DGTEST_HAS_RTTI=0 -DHAVE_64BIT_BUILD=1 -DHAVE_ALLOCA_H=1 -DHAVE_BYTESWAP_H=1 -DHAVE_CLOCK_MONOTONIC=1 -DHAVE_CPUID_H=1 -DHAVE_DIRENT_H=1 -DHAVE_DLADDR=1 -DHAVE_DLOPEN=1 -DHAVE_FONTCONFIG_FCFREETYPE_H=1 -DHAVE_FTS_H=1 -DHAVE_FT_BITMAP_SIZE_Y_PPEM=1 -DHAVE_FT_GLYPHSLOT_EMBOLDEN=1 -DHAVE_FT_LOAD_SFNT_TABLE=1 -DHAVE_GETCONTEXT=1 -DHAVE_GETOPT_H=1 -DHAVE_GMTIME_R=1 -DHAVE_INTTYPES_H=1 -DHAVE_LCHOWN=1 -DHAVE_LINUX_IF_ADDR_H=1 -DHAVE_LINUX_PERF_EVENT_H=1 -DHAVE_LINUX_QUOTA_H=1 -DHAVE_LINUX_RTNETLINK_H=1 -DHAVE_LOCALECONV=1 -DHAVE_LOCALTIME_R=1 -DHAVE_LSTAT64=1 -DHAVE_MALLINFO=1 -DHAVE_MALLOC_H=1 -DHAVE_MALLOC_USABLE_SIZE=1 -DHAVE_MEMALIGN=1 -DHAVE_MEMMEM=1 -DHAVE_NETINET_IN_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_POSIX_FADVISE=1 -DHAVE_POSIX_FALLOCATE=1 -DHAVE_POSIX_MEMALIGN=1 -DHAVE_PTHREAD_H=1 -DHAVE_RES_NINIT=1 -DHAVE_SETPRIORITY=1 -DHAVE_STAT64=1 -DHAVE_STDINT_H=1 -DHAVE_STRERROR=1 -DHAVE_STRNDUP=1 -DHAVE_SYSCALL=1 -DHAVE_SYS_QUEUE_H=1 -DHAVE_SYS_QUOTA_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_THREAD_TLS_KEYWORD=1 -DHAVE_TRUNCATE64=1 -DHAVE_UNISTD_H=1 -DHAVE_VALGRIND_VALGRIND_H=1 -DHAVE_VALLOC=1 -DHAVE_VA_COPY=1 -DHAVE_VA_LIST_AS_ARRAY=1 -DHAVE_VISIBILITY_ATTRIBUTE=1 -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE=1 -DJS_64BIT=1 -DJS_BUILD_BINAST=1 -DJS_CODEGEN_X64=1 -DJS_DEFAULT_JITREPORT_GRANULARITY=3 -DJS_HAS_INTL_API=1 -DJS_HAS_TYPED_OBJECTS=1 -DJS_PUNBOX64=1 -DJS_TRACE_LOGGING=1 -DMALLOC_H='<malloc.h>' -DMALLOC_USABLE_SIZE_CONST_PTR='' -DMOZILLA_UAVERSION='"77.0"' -DMOZILLA_VERSION='"77.0a1"' -DMOZILLA_VERSION_U=77.0a1 -DMOZ_ACCESSIBILITY_ATK=1 -DMOZ_APP_UA_NAME='""' -DMOZ_APP_UA_VERSION='"77.0a1"' -DMOZ_ASAN=1 -DMOZ_AV1=1 -DMOZ_BLOCK_PROFILE_DOWNGRADE=1 -DMOZ_BUILD_APP=browser -DMOZ_BUNDLED_FONTS=1 -DMOZ_CLANG_PLUGIN=1 -DMOZ_DATA_REPORTING=1 -DMOZ_DAV1D_ASM=1 -DMOZ_DEDICATED_PROFILES=1 -DMOZ_DISTRIBUTION_ID='"org.mozilla"' -DMOZ_DLL_PREFIX='"lib"' -DMOZ_DLL_SUFFIX='".so"' -DMOZ_ENABLE_DBUS=1 -DMOZ_ENABLE_FORKSERVER=1 -DMOZ_ENABLE_SKIA=1 -DMOZ_ENABLE_SKIA_PDF=1 -DMOZ_ENABLE_SKIA_PDF_SFNTLY=1 -DMOZ_FFMPEG=1 -DMOZ_FFVPX=1 -DMOZ_FMP4=1 -DMOZ_GECKO_PROFILER=1 -DMOZ_GECKO_PROFILER_PARSE_ELF=1 -DMOZ_GLEAN=1 -DMOZ_GLUE_IN_PROGRAM=1 -DMOZ_HAS_REMOTE=1 -DMOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_LIBAV_FFT=1 -DMOZ_LOGGING=1 -DMOZ_MACBUNDLE_ID=org.mozilla.nightly -DMOZ_NEW_CERT_STORAGE=1 -DMOZ_NEW_NOTIFICATION_STORE=1 -DMOZ_NEW_WEBEXT_STORAGE=1 -DMOZ_NEW_XULSTORE=1 -DMOZ_NORMANDY=1 -DMOZ_PEERCONNECTION=1 -DMOZ_PLACES=1 -DMOZ_PROFILER_MEMORY=1 -DMOZ_PULSEAUDIO=1 -DMOZ_RAW=1 -DMOZ_RUST_SIMD=1 -DMOZ_SAMPLE_TYPE_FLOAT32=1 -DMOZ_SCTP=1 -DMOZ_SERVICES_HEALTHREPORT=1 -DMOZ_SRTP=1 -DMOZ_STATIC_JS=1 -DMOZ_TREE_CAIRO=1 -DMOZ_TREE_PIXMAN=1 -DMOZ_UBSAN=1 -DMOZ_UPDATER=1 -DMOZ_UPDATE_CHANNEL=default -DMOZ_USER_DIR='".mozilla"' -DMOZ_USING_WASM_SANDBOXING=1 -DMOZ_VALGRIND=1 -DMOZ_VERIFY_MAR_SIGNATURE=1 -DMOZ_VORBIS=1 -DMOZ_WASM_SANDBOXING_GRAPHITE=1 -DMOZ_WASM_SANDBOXING_OGG=1 -DMOZ_WAYLAND=1 -DMOZ_WEBM_ENCODER=1 -DMOZ_WEBRTC=1 -DMOZ_WEBRTC_ASSERT_ALWAYS=1 -DMOZ_WEBRTC_SIGNALING=1 -DMOZ_WEBSPEECH=1 -DMOZ_WEBSPEECH_TEST_BACKEND=1 -DMOZ_WIDGET_GTK=1 -DMOZ_X11=1 -DMOZ_XUL=1 -DNIGHTLY_BUILD=1 -DNO_NSPR_10_SUPPORT=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DSTATIC_JS_API=1 -DSTDC_HEADERS=1 -DTARGET_XPCOM_ABI='"x86_64-gcc3"' -DUSE_SKIA=1 -DU_STATIC_IMPLEMENTATION=1 -DU_USING_ICU_NAMESPACE=0 -DVA_COPY=va_copy -DWASM_PRIVATE_REFTYPES=1 -DXP_LINUX=1 -DXP_UNIX=1 -D_REENTRANT=1 -DAB_CD=en-US /builds/worker/checkouts/gecko/browser/themes/linux/jar.mn
[task 2020-04-27T14:48:57.347Z] 14:48:57     INFO -  processing /builds/worker/checkouts/gecko/browser/themes/linux/jar.mn
[task 2020-04-27T14:48:57.347Z] 14:48:57    ERROR -  Traceback (most recent call last):
[task 2020-04-27T14:48:57.347Z] 14:48:57     INFO -    File "/usr/lib/python3.5/runpy.py", line 193, in _run_module_as_main
[task 2020-04-27T14:48:57.347Z] 14:48:57     INFO -      "__main__", mod_spec)
[task 2020-04-27T14:48:57.347Z] 14:48:57     INFO -    File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
[task 2020-04-27T14:48:57.347Z] 14:48:57     INFO -      exec(code, run_globals)
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/jar_maker.py", line 17, in <module>
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -      sys.exit(main(sys.argv[1:]))
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/jar_maker.py", line 13, in main
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -      return mozbuild.jar.main(args)
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/jar.py", line 616, in main
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -      jm.makeJar(infile, options.d)
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/jar.py", line 337, in makeJar
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -      self.processJarSection(info, jardir)
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/jar.py", line 392, in processJarSection
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -      self._processEntryLine(e, outHelper, jf)
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/jar.py", line 464, in _processEntryLine
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -      ', '.join(src_base)))
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -  RuntimeError: File "../shared/controlcenter/info.svg" not found in /builds/worker/checkouts/gecko/browser/themes/linux, /builds/worker/workspace/obj-build/browser/themes/linux
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -  /builds/worker/checkouts/gecko/config/rules.mk:944: recipe for target 'libs' failed
[task 2020-04-27T14:48:57.348Z] 14:48:57    ERROR -  make[4]: *** [libs] Error 1
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/browser/themes/linux'
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -  /builds/worker/checkouts/gecko/config/recurse.mk:101: recipe for target 'browser/themes/linux/libs' failed
[task 2020-04-27T14:48:57.348Z] 14:48:57    ERROR -  make[3]: *** [browser/themes/linux/libs] Error 2
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -  /builds/worker/checkouts/gecko/config/recurse.mk:32: recipe for target 'libs' failed
[task 2020-04-27T14:48:57.348Z] 14:48:57    ERROR -  make[2]: *** [libs] Error 2
[task 2020-04-27T14:48:57.348Z] 14:48:57     INFO -  /builds/worker/checkouts/gecko/config/rules.mk:394: recipe for target 'default' failed
[task 2020-04-27T14:48:57.349Z] 14:48:57    ERROR -  make[1]: *** [default] Error 2
[task 2020-04-27T14:48:57.349Z] 14:48:57     INFO -  client.mk:125: recipe for target 'build' failed
[task 2020-04-27T14:48:57.349Z] 14:48:57     INFO -  make: *** [build] Error 2
[task 2020-04-27T14:48:57.350Z] 14:48:57     INFO -  314 compiler warnings present.
[task 2020-04-27T14:48:57.450Z] 14:48:57     INFO -  Notification center failed: Install notify-send (usually part of the libnotify package) to get a notification when the build finishes.
[task 2020-04-27T14:48:57.499Z] 14:48:57    ERROR - Return code: 2
[task 2020-04-27T14:48:57.499Z] 14:48:57  WARNING - setting return code to 2
[task 2020-04-27T14:48:57.499Z] 14:48:57    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2020-04-27T14:48:57.499Z] 14:48:57    FATAL - Running post_fatal callback...
[task 2020-04-27T14:48:57.500Z] 14:48:57    FATAL - Exiting -1
[task 2020-04-27T14:48:57.500Z] 14:48:57     INFO - [mozharness: 2020-04-27 14:48:57.500033Z] Finished build step (failed)
[task 2020-04-27T14:48:57.500Z] 14:48:57     INFO - Running post-run listener: _parse_build_tests_ccov

Comment 10

[Jayati Shrivastava]

patch updated :)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db3d6719725e
Remove unused CSS and SVG related to protections-popup-trackersView-strict-info. r=nhnt11

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/db3d6719725e