1631005 - [wpt-sync] Sync PR 23065 - [css-grid] Migrate grid-gutters-and-tracks.html to WPT

Status: RESOLVED DUPLICATE of bug 1630973

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23065 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23065
Details from upstream follow.

Antonio Gomes <[e-mail]> wrote:

[css-grid] Migrate grid-gutters-and-tracks.html to WPT

BUG=767015, 1063749
R=[e-mail]

Change-Id: I407fbd42550a4e7b99676cbf509164a147cc4804
Reviewed-on: https://chromium-review.googlesource.com/2153731
WPT-Export-Revision: b74556c3826d0dc5fa53ef30b4bd3b8cae178271

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f578235e0c5603c20a1b3df26f6ffb86c77b05d

Comment 2

[Tiaan Louw [:tlouw]]

This test is passing, but there are timeouts allowed for "if (os == "android") and fission: [OK, TIMEOUT]". Should this bug stay open until that is resolved?

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Tiaan Louw from comment #2)

This test is passing, but there are timeouts allowed for "if (os == "android") and fission: [OK, TIMEOUT]".
Should this bug stay open until that is resolved?

No, let's close this. This bug here is a mechanical bug for use by WPT-sync-bot, and per comment 0, this was intended to be closed as soon as a sync operation was complete. (The sync operations aren't immediate/trivial since they do involve adding/updating test pass/fail expectations, which involve try runs like comment 1. But once we've got things hammered out and are able to complete the sync, this sort of bug is intended to be closed.)

Something must have gone haywire in this case, but we've surely synced in these WPT changes (and many many newer WPT updates) since this bug was filed. Let's close this.

(The android+fission specific intermittent-timeout may be worth investigating in its own bug; but given that we're not shipping android fission yet, it's probably not a priority at the moment.)

Comment 4

[Daniel Holbert [:dholbert]]

Looks like the test actually landed in bug 1630973, so let's just dupe this there.

(There were two WPT pull requests & hence two different bugs for two different tests, but both tests ended up both being synced in https://hg.mozilla.org/integration/autoland/rev/77c27aa64ee8 for bug 1630973, for whatever reason.)