Closed Bug 1631089 Opened 4 years ago Closed 4 years ago

Perma TEST-UNEXPECTED-FAIL Firefox Browser Page ElementHandle.screenshot should take into account padding and border

Categories

(Remote Protocol :: Agent, defect, P1)

Product:
Remote Protocol
Component:
Agent
Version:
77 Branch
Type:
defect

Tracking

(firefox76 unaffected, firefox77 wontfix, firefox78 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 78
Tracking Flags:
Tracking Status
firefox76 --- unaffected
firefox77 --- wontfix
firefox78 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Regression)

Details

(Keywords: regression)

Attachments

(5 files)

screenshot-element-padding-border.png
159 bytes, image/png
Details
screenshot-element-padding-border-expected.png
153 bytes, image/png
Details
screenshot-element-padding-border-diff.png
179 bytes, image/png
Details
screenshot-element-padding-border.png (after bug 1631615)
159 bytes, image/png
Details
Bug 1631089 - [remote] Force sRGB tag for generated screenshots.
47 bytes, text/x-phabricator-request
Details | Review

This test fails for me locally on MacOS because the generated screenshot by Firefox is different compared to the reference image. What's strange is that the same test passes perfectly in CI:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&tier=1%2C2%2C3&searchStr=pup

Here the local failure details:

0:09.66 TEST_START: Firefox Browser Page ElementHandle.screenshot should take into account padding and border
 0:09.66 TEST_END: FAIL, expected PASS
 0:09.66 pid:36384 1) [FAIL] Firefox Browser Page ElementHandle.screenshot should take into account padding and border (screenshot.spec.js:137:5)
 0:09.66 pid:36384   Message:
 0:09.66 pid:36384     expect.toBeGolden failed: screenshot-element-padding-border.png mismatch! Output is saved in "output-firefox" directory
 0:09.66 pid:36384   Stack:
 0:09.66 pid:36384     Error: expect.toBeGolden failed: screenshot-element-padding-border.png mismatch! Output is saved in "output-firefox" directory
 0:09.67 pid:36384         at applyMatcher (/Users/henrik/code/gecko/remote/test/puppeteer/utils/testrunner/Matchers.js:48:15)
 0:09.67 pid:36384         at fit (/Users/henrik/code/gecko/remote/test/puppeteer/test/screenshot.spec.js:152:26)
 0:09.67 pid:36384         at process._tickCallback (internal/process/next_tick.js:68:7)

Andrew, any idea why that's only failing on MacOS? What would have to be done to the reference image (will upload it in a moment) to get the test fixed, but also let it pass when using Chrome?

Flags: needinfo?(aosmond)

The temporary solution might be to set gfx.color_management.mode back to 2 for the moment.

To run the test do the following:

  1. Open https://searchfox.org/mozilla-central/rev/aec63591821712236a522f7f55116f582ed7c920/remote/test/puppeteer/test/screenshot.spec.js#137
  2. Change it( to fit( and save the file
  3. Execute ./mach puppeteer-test -vv --subset

Preview on MacOS shows that both images do not have an ICC profile attached. And while having the same image size both images differ by 6 bytes. I'm not that familiar with the PNG format yet to immediately figure out the reason what's different.

I assume that this actually could be related to drawSnapshot() which we make use of when creating the screenshot.

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #5)

I assume that this actually could be related to drawSnapshot() which we make use of when creating the screenshot.

Matt do we take color management into account when creating the screenshots? We clearly get different data returned by drawSnapshot() now that full color management has been turned on via bug 455077.

Flags: needinfo?(matt.woodrow)

I'm not really sure how the color management works, we'll have to wait for Andrew to reply.

It looks like color management is applied when we convert the display list into Moz2D drawing commands, so the recording should contain device colors, and I'd expect it to work identically between snapshots and normal rendering.

Flags: needinfo?(matt.woodrow)

Matt, so you are saying we cannot use some reference image as created by some other tool for asserting correct screenshot creation?

Oh, so the screenshots are now color correct, and the reference images aren't?

I suspect we'd need multiple sets of reference images, or use firefox to generate them somehow.

Yes, that is correct. But what is strange the CI build on Linux opt still works fine and the test passes:

https://treeherder.mozilla.org/logviewer.html#?job_id=298595246&repo=mozilla-central

[task 2020-04-21T10:18:46.738Z] TEST-START | Firefox Browser Page ElementHandle.screenshot should take into account padding and border
[task 2020-04-21T10:18:46.738Z] TEST-PASS | Firefox Browser Page ElementHandle.screenshot should take into account padding and border | took 0ms
[task 2020-04-21T10:18:46.739Z] PID 85 | 484) [ OK ] Firefox Browser Page ElementHandle.screenshot should take into account padding and border (screenshot.spec.js:137:5)

By flipping the pref I would have expected that we change the behavior platform wide.

Sadly we don't have the tests running for MacOS in CI yet to verify it. Not sure if this might be just a local thing which affects only me. Comment 3 has some steps in how to reproduce it.

If it isn't color managed in Chrome, I expect bug 1631615 to help with this. Let me know if it doesn't.

Flags: needinfo?(aosmond) → needinfo?(hskupin)

Sadly the test is still failing. Attached you can find the generated JPG image from after bug 1631615 has been fixed. There are still differences.

Flags: needinfo?(hskupin) → needinfo?(aosmond)

It would be good to know which impact that actually has. There might be other tools too, which will do image comparison, and once the first firefox beta 77 is out we might get further feedback from the community.

status-firefox76: --- → unaffected
status-firefox77: --- → affected
status-firefox78: --- → affected

Maybe lets move this bug to Core : GFX color management and get it re-triaged.

Component: Agent → GFX: Color Management
Priority: P5 → --
Product: Remote Protocol → Core

So we concluded gfx.color_management.force_srgb is what we need for marionette. This brings us back to the old behaviour for this particular test, as well as producing a consistent result no matter what monitor is used by the user (I imagine this is quite useful). It will also convert images that are tagged and used in the snapshot to sRGB which it did not do better (but seems much more correct). The main thing that is missing is tagged the resulting image as sRGB by default so that it will draw as expected in any browser. I intend to add support to the image encoders for this in bug 1615395.

Flags: needinfo?(aosmond)
See Also: → 1635670

Thanks Andrew. I will get this implemented for the remote protocol and Marionette/geckodriver. For the latter I filed bug 1635670.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P1

With full color management enabled in bug 455077 generated
screenshots will not be saved as sRGB when the display has
a different ICC profile. As long as bug 1615395 hasn't been
fixed, force screenshots to be saved as sRGB.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5deb673380d6
[remote] Force sRGB tag for generated screenshots. r=remote-protocol-reviewers,jgraham

https://hg.mozilla.org/mozilla-central/rev/5deb673380d6

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox78: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78

The landing of this patch actually caused a crash (see bug 1635861) because it shouldn't be set during runtime due to some known flakiness. As such we really have to put it into Puppeteer itself.

Sheriffs can you please backout the patch? Thanks.

Component: GFX: Color Management → Agent
Flags: needinfo?(sheriffs)
Product: Core → Remote Protocol
Target Milestone: mozilla78 → ---
Status: RESOLVED → REOPENED
status-firefox78: fixed → affected
Resolution: FIXED → ---

Backed out changeset 5deb673380d6 (bug 1631089) for causing bug 1635861

Backout link: https://hg.mozilla.org/integration/autoland/rev/6df4b3d1935afeaef41453cb9c07ca56e183f1d1

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301061337&repo=autoland&lineNumber=1679

[task 2020-05-06T17:15:29.497Z] 17:15:29     INFO - TEST-START | remote/test/browser/browser_tabs.js
[task 2020-05-06T17:15:29.919Z] 17:15:29     INFO - GECKO(1242) | 1588785329913	RemoteAgent	TRACE	(connection {e85e7eba-50f9-4f4a-b8f4-be32aa3e62df})-> {"id":1,"method":"Target.setDiscoverTargets","params":{"discover":true}}
[task 2020-05-06T17:15:29.919Z] 17:15:29     INFO - GECKO(1242) | 1588785329913	RemoteAgent	TRACE	<-(connection {e85e7eba-50f9-4f4a-b8f4-be32aa3e62df}) {"method":"Target.targetCreated","params":{"targetInfo":{"browserContextId":null,"targetId":"dd50f07a-dbd4-4f17-b651-9188b69f4228","type":"page","url":"about:blank"}}}
[task 2020-05-06T17:15:29.919Z] 17:15:29     INFO - GECKO(1242) | 1588785329913	RemoteAgent	TRACE	<-(connection {e85e7eba-50f9-4f4a-b8f4-be32aa3e62df}) {"method":"Target.targetCreated","params":{"targetInfo":{"targetId":"ea7998fe-19f2-4032-aaa2-26eeeea032d3","type":"browser"}}}
[task 2020-05-06T17:15:29.919Z] 17:15:29     INFO - GECKO(1242) | 1588785329913	RemoteAgent	TRACE	<-(connection {e85e7eba-50f9-4f4a-b8f4-be32aa3e62df}) {"method":"Target.targetCreated","params":{"targetInfo":{"browserContextId":null,"targetId":"3c3acd9a-2c4d-493b-985e-13663ec43505","type":"page","url":"about:blank"}}}
[task 2020-05-06T17:15:29.919Z] 17:15:29     INFO - GECKO(1242) | 1588785329913	RemoteAgent	TRACE	<-(connection {e85e7eba-50f9-4f4a-b8f4-be32aa3e62df}) {"id":1}
[task 2020-05-06T17:15:29.934Z] 17:15:29     INFO - GECKO(1242) | 1588785329922	RemoteAgent	TRACE	<-(connection {e85e7eba-50f9-4f4a-b8f4-be32aa3e62df}) {"method":"Target.targetCreated","params":{"targetInfo":{"browserContextId":null,"targetId":"a0dde587-dba0-4ea7-ad2f-64de6ec02bf9","type":"page","url":"about:blank"}}}
[task 2020-05-06T17:15:29.970Z] 17:15:29     INFO - GECKO(1242) | 1588785329961	RemoteAgent	TRACE	<-(connection {e85e7eba-50f9-4f4a-b8f4-be32aa3e62df}) {"method":"Target.targetDestroyed","params":{"targetId":"a0dde587-dba0-4ea7-ad2f-64de6ec02bf9"}}
[task 2020-05-06T17:15:29.986Z] 17:15:29     INFO - GECKO(1242) | 1588785329984	RemoteAgent	TRACE	<-(connection {e85e7eba-50f9-4f4a-b8f4-be32aa3e62df}) {"method":"Target.targetDestroyed","params":{"targetId":"3c3acd9a-2c4d-493b-985e-13663ec43505"}}
[task 2020-05-06T17:15:30.009Z] 17:15:30     INFO - GECKO(1242) | 1588785330003	RemoteAgent	TRACE	<-(connection {e85e7eba-50f9-4f4a-b8f4-be32aa3e62df}) {"method":"Target.targetDestroyed","params":{"targetId":"dd50f07a-dbd4-4f17-b651-9188b69f4228"}}
[task 2020-05-06T17:15:30.009Z] 17:15:30     INFO - GECKO(1242) | 1588785330003	RemoteAgent	TRACE	<-(connection {e85e7eba-50f9-4f4a-b8f4-be32aa3e62df}) {"method":"Target.targetDestroyed","params":{"targetId":"ea7998fe-19f2-4032-aaa2-26eeeea032d3"}}
[task 2020-05-06T17:15:30.025Z] 17:15:30     INFO - GECKO(1242) | MEMORY STAT | vsize 2978MB | residentFast 335MB | heapAllocated 132MB
[task 2020-05-06T17:15:30.025Z] 17:15:30     INFO - TEST-OK | remote/test/browser/browser_tabs.js | took 528ms
[task 2020-05-06T17:15:30.061Z] 17:15:30     INFO - checking window state
[task 2020-05-06T17:15:31.719Z] 17:15:31     INFO - GECKO(1242) | Completed ShutdownLeaks collections in process 1615
[task 2020-05-06T17:15:31.728Z] 17:15:31     INFO - GECKO(1242) | Completed ShutdownLeaks collections in process 1560
[task 2020-05-06T17:15:31.763Z] 17:15:31     INFO - GECKO(1242) | Completed ShutdownLeaks collections in process 1673
[task 2020-05-06T17:15:31.781Z] 17:15:31     INFO - GECKO(1242) | Completed ShutdownLeaks collections in process 1689
[task 2020-05-06T17:15:31.782Z] 17:15:31     INFO - GECKO(1242) | Completed ShutdownLeaks collections in process 1532
[task 2020-05-06T17:15:31.783Z] 17:15:31     INFO - GECKO(1242) | Completed ShutdownLeaks collections in process 1645
[task 2020-05-06T17:15:31.784Z] 17:15:31     INFO - GECKO(1242) | Completed ShutdownLeaks collections in process 1415
[task 2020-05-06T17:15:31.799Z] 17:15:31     INFO - GECKO(1242) | Completed ShutdownLeaks collections in process 1347
[task 2020-05-06T17:15:31.847Z] 17:15:31     INFO - GECKO(1242) | Completed ShutdownLeaks collections in process 1361
[task 2020-05-06T17:15:31.867Z] 17:15:31     INFO - GECKO(1242) | Completed ShutdownLeaks collections in process 1538
[task 2020-05-06T17:15:32.321Z] 17:15:32     INFO - GECKO(1242) | Completed ShutdownLeaks collections in process 1242
[task 2020-05-06T17:15:32.322Z] 17:15:32     INFO - TEST-START | Shutdown
[task 2020-05-06T17:15:32.322Z] 17:15:32     INFO - Browser Chrome Test Summary
[task 2020-05-06T17:15:32.323Z] 17:15:32     INFO - Passed:  23
[task 2020-05-06T17:15:32.323Z] 17:15:32     INFO - Failed:  0
[task 2020-05-06T17:15:32.323Z] 17:15:32     INFO - Todo:    0
[task 2020-05-06T17:15:32.323Z] 17:15:32     INFO - Mode:    e10s
[task 2020-05-06T17:15:32.325Z] 17:15:32     INFO - *** End BrowserChrome Test Results ***
[task 2020-05-06T17:15:32.806Z] 17:15:32     INFO - GECKO(1242) | 1588785332801	Marionette	TRACE	Received observer notification xpcom-will-shutdown
[task 2020-05-06T17:15:32.808Z] 17:15:32     INFO - GECKO(1242) | 1588785332801	Marionette	INFO	Stopped listening on port 2828
[task 2020-05-06T17:15:32.809Z] 17:15:32     INFO - GECKO(1242) | 1588785332801	Marionette	DEBUG	Marionette stopped listening
[task 2020-05-06T17:15:32.862Z] 17:15:32     INFO - GECKO(1242) | ###!!! [Child][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-05-06T17:15:33.111Z] 17:15:33     INFO - TEST-INFO | Main app process: exit 0
[task 2020-05-06T17:15:33.112Z] 17:15:33     INFO - runtests.py | Application ran for: 0:00:14.555040
[task 2020-05-06T17:15:33.112Z] 17:15:33     INFO - zombiecheck | Reading PID log: /tmp/tmp1ixoXhpidlog
[task 2020-05-06T17:15:33.114Z] 17:15:33     INFO - ==> process 1242 launched child process 1264
[task 2020-05-06T17:15:33.115Z] 17:15:33     INFO - ==> process 1242 launched child process 1281
[task 2020-05-06T17:15:33.116Z] 17:15:33     INFO - ==> process 1242 launched child process 1347
[task 2020-05-06T17:15:33.116Z] 17:15:33     INFO - ==> process 1242 launched child process 1361
[task 2020-05-06T17:15:33.117Z] 17:15:33     INFO - ==> process 1242 launched child process 1415
[task 2020-05-06T17:15:33.117Z] 17:15:33     INFO - ==> process 1242 launched child process 1475
[task 2020-05-06T17:15:33.118Z] 17:15:33     INFO - ==> process 1242 launched child process 1530
[task 2020-05-06T17:15:33.118Z] 17:15:33     INFO - ==> process 1242 launched child process 1532
[task 2020-05-06T17:15:33.119Z] 17:15:33     INFO - ==> process 1242 launched child process 1538
[task 2020-05-06T17:15:33.119Z] 17:15:33     INFO - ==> process 1242 launched child process 1560
[task 2020-05-06T17:15:33.120Z] 17:15:33     INFO - ==> process 1242 launched child process 1615
[task 2020-05-06T17:15:33.120Z] 17:15:33     INFO - ==> process 1242 launched child process 1645
[task 2020-05-06T17:15:33.121Z] 17:15:33     INFO - ==> process 1242 launched child process 1673
[task 2020-05-06T17:15:33.121Z] 17:15:33     INFO - ==> process 1242 launched child process 1689
[task 2020-05-06T17:15:33.122Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1281
[task 2020-05-06T17:15:33.122Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1538
[task 2020-05-06T17:15:33.123Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1347
[task 2020-05-06T17:15:33.123Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1415
[task 2020-05-06T17:15:33.123Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1673
[task 2020-05-06T17:15:33.124Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1645
[task 2020-05-06T17:15:33.124Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1615
[task 2020-05-06T17:15:33.124Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1264
[task 2020-05-06T17:15:33.124Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1361
[task 2020-05-06T17:15:33.125Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1475
[task 2020-05-06T17:15:33.125Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1560
[task 2020-05-06T17:15:33.125Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1689
[task 2020-05-06T17:15:33.126Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1530
[task 2020-05-06T17:15:33.126Z] 17:15:33     INFO - zombiecheck | Checking for orphan process with PID: 1532
[task 2020-05-06T17:15:33.126Z] 17:15:33     INFO - mozcrash Downloading symbols from: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/f7ovpyQxTSC5AsO7koUp4w/artifacts/public/build/target.crashreporter-symbols.zip
[task 2020-05-06T17:15:37.540Z] 17:15:37     INFO - mozcrash Copy/paste: /builds/worker/fetches/minidump_stackwalk/minidump_stackwalk /tmp/tmpmHfnf8.mozrunner/minidumps/676d7c0b-fae2-5a4d-21c4-ef01df9e4f60.dmp /tmp/tmpsckPAR
[task 2020-05-06T17:15:42.755Z] 17:15:42     INFO - mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/676d7c0b-fae2-5a4d-21c4-ef01df9e4f60.dmp
[task 2020-05-06T17:15:42.755Z] 17:15:42     INFO - mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/676d7c0b-fae2-5a4d-21c4-ef01df9e4f60.extra
[task 2020-05-06T17:15:42.855Z] 17:15:42     INFO - PROCESS-CRASH | Main app process exited normally | application crashed [@ build_input_gamma_table]
[task 2020-05-06T17:15:42.855Z] 17:15:42     INFO - Crash dump filename: /tmp/tmpmHfnf8.mozrunner/minidumps/676d7c0b-fae2-5a4d-21c4-ef01df9e4f60.dmp
[task 2020-05-06T17:15:42.856Z] 17:15:42     INFO - Operating system: Linux
[task 2020-05-06T17:15:42.856Z] 17:15:42     INFO -                   0.0.0 Linux 4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018 x86_64
[task 2020-05-06T17:15:42.856Z] 17:15:42     INFO - CPU: amd64
[task 2020-05-06T17:15:42.856Z] 17:15:42     INFO -      family 6 model 85 stepping 4
[task 2020-05-06T17:15:42.856Z] 17:15:42     INFO -      2 CPUs
[task 2020-05-06T17:15:42.856Z] 17:15:42     INFO - 
[task 2020-05-06T17:15:42.856Z] 17:15:42     INFO - GPU: UNKNOWN
[task 2020-05-06T17:15:42.856Z] 17:15:42     INFO - 
[task 2020-05-06T17:15:42.856Z] 17:15:42     INFO - Crash reason:  SIGSEGV /SEGV_MAPERR
[task 2020-05-06T17:15:42.856Z] 17:15:42     INFO - Crash address: 0x7feca62b5ef4
[task 2020-05-06T17:15:42.856Z] 17:15:42     INFO - Process uptime: not available
[task 2020-05-06T17:15:42.857Z] 17:15:42     INFO - 
[task 2020-05-06T17:15:42.857Z] 17:15:42     INFO - Thread 13 (crashed)
[task 2020-05-06T17:15:42.857Z] 17:15:42     INFO -  0  libxul.so!build_input_gamma_table [transform_util.c:6ead09696c1a62465f50dde345b7d54ba77eda91 : 201 + 0x52]
[task 2020-05-06T17:15:42.857Z] 17:15:42     INFO -     rax = 0x00000000fe76ef67   rdx = 0x0000000000000000
[task 2020-05-06T17:15:42.857Z] 17:15:42     INFO -     rcx = 0xfffffffffe76ef68   rbx = 0x000000000000000f
[task 2020-05-06T17:15:42.857Z] 17:15:42     INFO -     rsi = 0x0000000000000000   rdi = 0x00007fecc2000020
[task 2020-05-06T17:15:42.857Z] 17:15:42     INFO -     rbp = 0x00007feca88bd040   rsp = 0x00007feca88bcfe0
[task 2020-05-06T17:15:42.857Z] 17:15:42     INFO -      r8 = 0x0000000000000000    r9 = 0x0000000000000001
[task 2020-05-06T17:15:42.857Z] 17:15:42     INFO -     r10 = 0x0000000000000000   r11 = 0x00007fecc23a54c0
[task 2020-05-06T17:15:42.857Z] 17:15:42     INFO -     r12 = 0x00000000fe76ef68   r13 = 0x00007feca7484820
[task 2020-05-06T17:15:42.857Z] 17:15:42     INFO -     r14 = 0x00007feca86ee800   r15 = 0x00007feca93d8000
[task 2020-05-06T17:15:42.858Z] 17:15:42     INFO -     rip = 0x00007fecb50aea57
[task 2020-05-06T17:15:42.858Z] 17:15:42     INFO -     Found by: given as instruction pointer in context
[task 2020-05-06T17:15:42.858Z] 17:15:42     INFO -  1  libxul.so!qcms_transform_create [transform.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 1285 + 0x9]
[task 2020-05-06T17:15:42.858Z] 17:15:42     INFO -     rbx = 0x0000000000000001   rbp = 0x00007feca88bd1d0
[task 2020-05-06T17:15:42.858Z] 17:15:42     INFO -     rsp = 0x00007feca88bd050   r12 = 0x0000000000000002
[task 2020-05-06T17:15:42.858Z] 17:15:42     INFO -     r13 = 0x00007feca7484820   r14 = 0x00007fecae918880
[task 2020-05-06T17:15:42.858Z] 17:15:42     INFO -     r15 = 0x00007fecae918880   rip = 0x00007fecb50b23e6
[task 2020-05-06T17:15:42.858Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.858Z] 17:15:42     INFO -  2  libxul.so!gfxPlatform::GetCMSBGRATransform() [gfxPlatform.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 2269 + 0x15]
[task 2020-05-06T17:15:42.858Z] 17:15:42     INFO -     rbx = 0x00007fecae918880   rbp = 0x00007feca88bd1f0
[task 2020-05-06T17:15:42.858Z] 17:15:42     INFO -     rsp = 0x00007feca88bd1e0   r12 = 0x00007feca86ed038
[task 2020-05-06T17:15:42.859Z] 17:15:42     INFO -     r13 = 0x00007feca88bd298   r14 = 0x00007feca88bd298
[task 2020-05-06T17:15:42.859Z] 17:15:42     INFO -     r15 = 0x0000000000000000   rip = 0x00007fecb513ae56
[task 2020-05-06T17:15:42.859Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.859Z] 17:15:42     INFO -  3  libxul.so!mozilla::image::nsBMPDecoder::ReadBitfields(char const*, unsigned long) [nsBMPDecoder.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 0 + 0x5]
[task 2020-05-06T17:15:42.859Z] 17:15:42     INFO -     rbx = 0x00007feca86ed000   rbp = 0x00007feca88bd220
[task 2020-05-06T17:15:42.859Z] 17:15:42     INFO -     rsp = 0x00007feca88bd200   r12 = 0x00007feca86ed038
[task 2020-05-06T17:15:42.859Z] 17:15:42     INFO -     r13 = 0x00007feca88bd298   r14 = 0x00007feca88bd298
[task 2020-05-06T17:15:42.859Z] 17:15:42     INFO -     r15 = 0x0000000000000000   rip = 0x00007fecb1807767
[task 2020-05-06T17:15:42.859Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.859Z] 17:15:42     INFO -  4  libxul.so!mozilla::image::nsBMPDecoder::DoDecode(mozilla::image::SourceBufferIterator&, mozilla::image::IResumable*) [nsBMPDecoder.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 430 + 0xcd]
[task 2020-05-06T17:15:42.860Z] 17:15:42     INFO -     rbx = 0x00007feca86ed000   rbp = 0x00007feca88bd2f0
[task 2020-05-06T17:15:42.860Z] 17:15:42     INFO -     rsp = 0x00007feca88bd230   r12 = 0x00007feca86ed038
[task 2020-05-06T17:15:42.860Z] 17:15:42     INFO -     r13 = 0x00007feca88bd298   r14 = 0x00007feca86ed1b0
[task 2020-05-06T17:15:42.860Z] 17:15:42     INFO -     r15 = 0x0000000000000000   rip = 0x00007fecb51906c0
[task 2020-05-06T17:15:42.860Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.860Z] 17:15:42     INFO -  5  libxul.so!mozilla::image::Decoder::Decode(mozilla::image::IResumable*) [Decoder.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 172 + 0x17]
[task 2020-05-06T17:15:42.860Z] 17:15:42     INFO -     rbx = 0x00007feca86c8760   rbp = 0x00007feca88bd350
[task 2020-05-06T17:15:42.860Z] 17:15:42     INFO -     rsp = 0x00007feca88bd300   r12 = 0x00007feca86ed000
[task 2020-05-06T17:15:42.860Z] 17:15:42     INFO -     r13 = 0x000030a7638402d2   r14 = 0x00007feca88bd370
[task 2020-05-06T17:15:42.861Z] 17:15:42     INFO -     r15 = 0x7fffffffffffffff   rip = 0x00007fecb516bfa6
[task 2020-05-06T17:15:42.861Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.861Z] 17:15:42     INFO -  6  libxul.so!<name omitted> [nsICODecoder.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 684 + 0x12]
[task 2020-05-06T17:15:42.861Z] 17:15:42     INFO -     rbx = 0x00007feca893ec00   rbp = 0x00007feca88bd390
[task 2020-05-06T17:15:42.861Z] 17:15:42     INFO -     rsp = 0x00007feca88bd360   r12 = 0x0000000000000000
[task 2020-05-06T17:15:42.861Z] 17:15:42     INFO -     r13 = 0x00007feca893ed80   r14 = 0x00007feca88bd548
[task 2020-05-06T17:15:42.861Z] 17:15:42     INFO -     r15 = 0x00007feca86ed000   rip = 0x00007fecb51932fd
[task 2020-05-06T17:15:42.861Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.861Z] 17:15:42     INFO -  7  libxul.so!mozilla::image::nsICODecoder::ReadBIH(char const*) [nsICODecoder.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 425 + 0x8]
[task 2020-05-06T17:15:42.862Z] 17:15:42     INFO -     rbx = 0x00007feca893ec00   rbp = 0x00007feca88bd440
[task 2020-05-06T17:15:42.862Z] 17:15:42     INFO -     rsp = 0x00007feca88bd3a0   r12 = 0x0000000000000000
[task 2020-05-06T17:15:42.862Z] 17:15:42     INFO -     r13 = 0x00007feca893ed80   r14 = 0x00007feca88bd548
[task 2020-05-06T17:15:42.862Z] 17:15:42     INFO -     r15 = 0x00007feca86ed000   rip = 0x00007fecb1809292
[task 2020-05-06T17:15:42.862Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.862Z] 17:15:42     INFO -  8  libxul.so!mozilla::image::nsICODecoder::SniffResource(char const*) [nsICODecoder.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 370 + 0xb]
[task 2020-05-06T17:15:42.862Z] 17:15:42     INFO -     rbx = 0x00007feca893ec00   rbp = 0x00007feca88bd4e0
[task 2020-05-06T17:15:42.862Z] 17:15:42     INFO -     rsp = 0x00007feca88bd450   r12 = 0x00007feca893ec38
[task 2020-05-06T17:15:42.863Z] 17:15:42     INFO -     r13 = 0x00007feca893ed80   r14 = 0x00007feca88bd548
[task 2020-05-06T17:15:42.863Z] 17:15:42     INFO -     r15 = 0x00007feca665ef38   rip = 0x00007fecb1809010
[task 2020-05-06T17:15:42.863Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.863Z] 17:15:42     INFO -  9  libxul.so!mozilla::image::nsICODecoder::DoDecode(mozilla::image::SourceBufferIterator&, mozilla::image::IResumable*) [nsICODecoder.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 639 + 0xc8]
[task 2020-05-06T17:15:42.863Z] 17:15:42     INFO -     rbx = 0x00007feca893ec00   rbp = 0x00007feca88bd5a0
[task 2020-05-06T17:15:42.863Z] 17:15:42     INFO -     rsp = 0x00007feca88bd4f0   r12 = 0x00007feca893ec38
[task 2020-05-06T17:15:42.863Z] 17:15:42     INFO -     r13 = 0x00007feca893ed80   r14 = 0x00007feca88bd548
[task 2020-05-06T17:15:42.863Z] 17:15:42     INFO -     r15 = 0x00007feca665ef38   rip = 0x00007fecb5193e9d
[task 2020-05-06T17:15:42.863Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.864Z] 17:15:42     INFO - 10  libxul.so!mozilla::image::Decoder::Decode(mozilla::image::IResumable*) [Decoder.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 172 + 0x17]
[task 2020-05-06T17:15:42.864Z] 17:15:42     INFO -     rbx = 0x00007feca86c8760   rbp = 0x00007feca88bd600
[task 2020-05-06T17:15:42.864Z] 17:15:42     INFO -     rsp = 0x00007feca88bd5b0   r12 = 0x00007feca893ec00
[task 2020-05-06T17:15:42.864Z] 17:15:42     INFO -     r13 = 0x000030a76383d9bc   r14 = 0x00007feca88bd618
[task 2020-05-06T17:15:42.864Z] 17:15:42     INFO -     r15 = 0x7fffffffffffffff   rip = 0x00007fecb516bfa6
[task 2020-05-06T17:15:42.864Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.864Z] 17:15:42     INFO - 11  libxul.so!mozilla::image::DecodedSurfaceProvider::Run() [DecodedSurfaceProvider.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 122 + 0x8]
[task 2020-05-06T17:15:42.864Z] 17:15:42     INFO -     rbx = 0x00007feca665eef0   rbp = 0x00007feca88bd650
[task 2020-05-06T17:15:42.865Z] 17:15:42     INFO -     rsp = 0x00007feca88bd610   r12 = 0x0000000000000000
[task 2020-05-06T17:15:42.865Z] 17:15:42     INFO -     r13 = 0x0000000000000000   r14 = 0x00007feca665ef58
[task 2020-05-06T17:15:42.865Z] 17:15:42     INFO -     r15 = 0x00007feca665ef38   rip = 0x00007fecb516d520
[task 2020-05-06T17:15:42.865Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.865Z] 17:15:42     INFO - 12  libxul.so!mozilla::image::DecodePoolWorker::Run() [DecodePool.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 276 + 0xd]
[task 2020-05-06T17:15:42.865Z] 17:15:42     INFO -     rbx = 0x00007feca665ef38   rbp = 0x00007feca88bd6c0
[task 2020-05-06T17:15:42.865Z] 17:15:42     INFO -     rsp = 0x00007feca88bd660   r12 = 0x0000000000000000
[task 2020-05-06T17:15:42.865Z] 17:15:42     INFO -     r13 = 0x0000000000000000   r14 = 0x00007feca931dd50
[task 2020-05-06T17:15:42.865Z] 17:15:42     INFO -     r15 = 0x00007feca86a6ca0   rip = 0x00007fecb517031d
[task 2020-05-06T17:15:42.866Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.866Z] 17:15:42     INFO - 13  libxul.so!nsThread::ProcessNextEvent(bool, bool*) [nsThread.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 1200 + 0x6]
[task 2020-05-06T17:15:42.866Z] 17:15:42     INFO -     rbx = 0x0000000000000000   rbp = 0x00007feca88bdbf0
[task 2020-05-06T17:15:42.866Z] 17:15:42     INFO -     rsp = 0x00007feca88bd6d0   r12 = 0x00007feca8624200
[task 2020-05-06T17:15:42.866Z] 17:15:42     INFO -     r13 = 0x0000000000000000   r14 = 0x0000000000000000
[task 2020-05-06T17:15:42.866Z] 17:15:42     INFO -     r15 = 0x00000000ffffffff   rip = 0x00007fecb44430e4
[task 2020-05-06T17:15:42.866Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.866Z] 17:15:42     INFO - 14  libxul.so!mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [nsThreadUtils.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 481 + 0x22]
[task 2020-05-06T17:15:42.866Z] 17:15:42     INFO -     rbx = 0x00007feca88bdc98   rbp = 0x00007feca88bdc40
[task 2020-05-06T17:15:42.867Z] 17:15:42     INFO -     rsp = 0x00007feca88bdc00   r12 = 0x00007feca93ed0a0
[task 2020-05-06T17:15:42.867Z] 17:15:42     INFO -     r13 = 0x00007feca878ab80   r14 = 0x00007feca93ed080
[task 2020-05-06T17:15:42.867Z] 17:15:42     INFO -     r15 = 0x00007feca8624200   rip = 0x00007fecb4eab0be
[task 2020-05-06T17:15:42.867Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.867Z] 17:15:42     INFO - 15  libxul.so!MessageLoop::Run() [message_loop.cc:6ead09696c1a62465f50dde345b7d54ba77eda91 : 290 + 0xc]
[task 2020-05-06T17:15:42.867Z] 17:15:42     INFO -     rbx = 0x00007feca88bdc98   rbp = 0x00007feca88bdc70
[task 2020-05-06T17:15:42.867Z] 17:15:42     INFO -     rsp = 0x00007feca88bdc50   r12 = 0x00007fecc1f38920
[task 2020-05-06T17:15:42.867Z] 17:15:42     INFO -     r13 = 0x00007feca878ab80   r14 = 0x00007ffc907f7990
[task 2020-05-06T17:15:42.867Z] 17:15:42     INFO -     r15 = 0x00007feca8624200   rip = 0x00007fecb4e87f4f
[task 2020-05-06T17:15:42.868Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.868Z] 17:15:42     INFO - 16  libxul.so!nsThread::ThreadFunc(void*) [nsThread.cpp:6ead09696c1a62465f50dde345b7d54ba77eda91 : 444 + 0x8]
[task 2020-05-06T17:15:42.868Z] 17:15:42     INFO -     rbx = 0x00007feca88bdc98   rbp = 0x00007feca88bde60
[task 2020-05-06T17:15:42.868Z] 17:15:42     INFO -     rsp = 0x00007feca88bdc80   r12 = 0x00007fecc1f38920
[task 2020-05-06T17:15:42.868Z] 17:15:42     INFO -     r13 = 0x00007feca878ab80   r14 = 0x00007ffc907f7990
[task 2020-05-06T17:15:42.868Z] 17:15:42     INFO -     r15 = 0x00007feca8624200   rip = 0x00007fecb4cb671e
[task 2020-05-06T17:15:42.868Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.868Z] 17:15:42     INFO - 17  libnspr4.so!_pt_root [ptthread.c:6ead09696c1a62465f50dde345b7d54ba77eda91 : 201 + 0x8]
[task 2020-05-06T17:15:42.869Z] 17:15:42     INFO -     rbx = 0x0000000000000002   rbp = 0x00007feca88bdeb0
[task 2020-05-06T17:15:42.869Z] 17:15:42     INFO -     rsp = 0x00007feca88bde70   r12 = 0x00007fecc1f38920
[task 2020-05-06T17:15:42.869Z] 17:15:42     INFO -     r13 = 0x00007feca878ab80   r14 = 0x00007feca88be700
[task 2020-05-06T17:15:42.869Z] 17:15:42     INFO -     r15 = 0x00000000000005d4   rip = 0x00007fecc371b4ae
[task 2020-05-06T17:15:42.869Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.869Z] 17:15:42     INFO - 18  libpthread.so.0 + 0x76db
[task 2020-05-06T17:15:42.869Z] 17:15:42     INFO -     rbx = 0x0000000000000000   rbp = 0x0000000000000000
[task 2020-05-06T17:15:42.869Z] 17:15:42     INFO -     rsp = 0x00007feca88bdec0   r12 = 0x00007feca88bdf80
[task 2020-05-06T17:15:42.869Z] 17:15:42     INFO -     r13 = 0x0000000000000000   r14 = 0x00007feca878ab80
[task 2020-05-06T17:15:42.870Z] 17:15:42     INFO -     r15 = 0x00007ffc907f78e8   rip = 0x00007fecc33396db
[task 2020-05-06T17:15:42.870Z] 17:15:42     INFO -     Found by: call frame info
[task 2020-05-06T17:15:42.870Z] 17:15:42     INFO - 19  libc.so.6 + 0x12188f
[task 2020-05-06T17:15:42.870Z] 17:15:42     INFO -     rsp = 0x00007feca88bdf80   rip = 0x00007fecc231788f
[task 2020-05-06T17:15:42.870Z] 17:15:42     INFO -     Found by: stack scanning
[task 2020-05-06T17:15:42.870Z] 17:15:42     INFO - 
...
Flags: needinfo?(sheriffs) → needinfo?(hskupin)

As noted by Andrew the problem here is related to some flakiness in the GFX system when setting the preference at runtime. As he suggested it has to be done before Firefox starts. My updated patch does this for Puppeteer only, given that for the browser chrome tests we have image comparisons.

Flags: needinfo?(hskupin)
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/463a3ae40b52
[remote] Force sRGB tag for generated screenshots. r=remote-protocol-reviewers,jgraham

https://hg.mozilla.org/mozilla-central/rev/463a3ae40b52

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox78: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: