Closed Bug 1631111 Opened 4 months ago Closed 3 months ago

[wpt-sync] Sync PR 23077 - Handle 'revert' in StylePropertySerializer::CommonShorthandChecks

Categories

(Core :: DOM: CSS Object Model, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23077 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23077
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

Handle 'revert' in StylePropertySerializer::CommonShorthandChecks

The 'initial', 'inherit' and 'unset' keywords were handled, but
'revert' was not. This caused crashes when trying to represent certain
declaration block serializations using shorthands.

Change to use IsCSSWideKeyword instead, which includes 'revert'.
(It should also avoid the same problem the next time a new CSS-wide
keyword is added).

Bug: 1071454
Change-Id: I968a32a5ad5b2a1a1958f60ec19679c6a642df14
Reviewed-on: https://chromium-review.googlesource.com/2152817
WPT-Export-Revision: 322eaf62a31bb7a3291134e31834bcc1213196fc

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 60 tests

Status Summary

Firefox

OK : 1
PASS: 7[GitHub] 66[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 1
PASS: 6
FAIL: 1

Safari

OK : 1
PASS: 5
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/577291b048fc
[wpt PR 23077] - Handle 'revert' in StylePropertySerializer::CommonShorthandChecks, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/d588c40a3387
[wpt PR 23077] - Handle 'revert' in StylePropertySerializer::CommonShorthandChecks, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.