[MIPS] Fix build failures on MIPS (error: member access into incomplete type 'js::jit::InvalidationBailoutStack')
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: zhaojiazhong-hf, Assigned: zhaojiazhong-hf)
Details
Attachments
(1 file)
|
Assignee | |
Comment 1•4 years ago
|
||
I failed to build js on mips64el machine after this patch: Bug 1628227 - Add WarpCacheIRTranspiler prototype. r?iain!, got:
.../js/src/jit/mips-shared/Bailouts-mips-shared.cpp:14:23: error: member access into incomplete type 'js::jit::InvalidationBailoutStack'
: machine_(bailout->machine()) {
^
.../js/src/jit/Bailouts.h:141:7: note: forward declaration of 'js::jit::InvalidationBailoutStack'
class InvalidationBailoutStack;
^
In file included from Unified_cpp_js_src_jit12.cpp:2:
......
.../js/src/jit/mips-shared/Bailouts-mips-shared.cpp:22:29: error: member access into incomplete type 'const js::jit::OsiIndex'
snapshotOffset_ = osiIndex->snapshotOffset();
^
.../js/src/jit/IonCode.h:150:7: note: forward declaration of 'js::jit::OsiIndex'
class OsiIndex;
^
And it seems that this bug is related to a former patch: Bug 1505689 part 5 - Move BaselineScript and IonScript pointers from JSScript to JitScript. r?tcampbell!, which included a new header file vm/JSScript-inl.h in both Bailouts-mips64.cpp and Bailouts-mips32.cpp, but didn't add it to Bailouts-mips-shared.cpp.
And according to my test, the error is gone after adding vm/JSScript-inl.h to Bailouts-mips-shared.cpp.
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b269f4ebb366 [MIPS] Include vm/JSScript-inl.h in Bailouts-mips-shared.cpp. r=jandem
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•