Open Bug 1631163 Opened 7 months ago Updated 3 months ago

Updated notification is wrong when mozregression runs from repo

Categories

(Testing :: mozregression, defect, P4)

defect

Tracking

(Not tracked)

UNCONFIRMED

People

(Reporter: raysatiro, Unassigned)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Launch mozregression and observe an incorrect update notification.

mozregression: 4.0.4.dev0+ga387b60.d20200417

Actual results:

In the GUI I see this notification:
"There is a new release available! Download the new release 4.0.3."

Expected results:

I guess 4.0.4.dev0+ga387b60.d20200417 is incorrectly parsed as less than 4.0.3.

The same issue is present when running it without GUI.

 0:00.23 WARNING: You are using mozregression version 4.0.4.dev0+ga387b60.d20200417, however version 4.0.2 is available.
 0:00.23 WARNING: You should consider upgrading via the 'pip install --upgrade mozregression' command.

We should be able to use a better version comparing heuristic, like this one from packaging:

https://stackoverflow.com/a/11887885

The code is here:

(it may be possible to consolidate some of this code, which in some cases is doing the exact same thing)

Ray, would you be interested in submitting a pull request?

Flags: needinfo?(raysatiro)

(In reply to William Lachance (:wlach) (use needinfo!) from comment #2)

Ray, would you be interested in submitting a pull request?

I can give it a shot. It may take a few days to get to it.

Flags: needinfo?(raysatiro)

The priority flag is not set for this bug.
:wlach, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(wlachance)
Flags: needinfo?(wlachance)
Priority: -- → P4

The severity field is not set for this bug.
:wlach, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(wlachance)
Flags: needinfo?(wlachance)
Duplicate of this bug: 1661851
You need to log in before you can comment on or make changes to this bug.