1631171 - Cannot delete or rename an existing profile using profile manager

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]:

STR:

1. start Nightly with -p option. i.e. firefox.exe -p
2. Attempt to rename or delete existing profile from profile manager
   (e.g. click on [Rename] and [Delete] button)

Actual Results:
Nothing happens.(No dialog pops up after click on [Rename] and [Delete] button.)

Expected Results:
Dialog should pop up.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=207cada5013283f4bd078c9648121dfe90ce5ac6&tochange=4b428169709db0fcbdf66f74aeab501a21885482

Comment 1

[Alice0775 White]

Debug build shows an error when click [Delete Profile] button:

(c) 2019 Microsoft Corporation. All rights reserved.

C:\Users\fuku>l:

L:\>cd "L:\trunk\2020\04\firefox17-Apr-2020 214650 debug"

L:\trunk\2020\04\firefox17-Apr-2020 214650 debug>firefox.exe -p
[4108, Main Thread] WARNING: dependent window created without a parent: file /builds/worker/checkouts/gecko/toolkit/components/startup/nsAppStartup.cpp, line 626
[4108, Main Thread] WARNING: NS_ENSURE_TRUE(root) failed: file /builds/worker/checkouts/gecko/layout/base/nsDocumentViewer.cpp, line 3106

L:\trunk\2020\04\firefox17-Apr-2020 214650 debug>JavaScript error: resource://gre/modules/Prompter.jsm, line 586: NotSupportedError: Operation is not supported
JavaScript error: resource://gre/modules/Prompter.jsm, line 586: NotSupportedError: Operation is not supported

Comment 2

[:Gijs (he/him)]

Paul, mind taking a look? Thanks!

Comment 3

[Paul Zühlcke [:pbz]]

Attachment: Bug 1631171 - Prompter.jsm: Fallback to window prompts if prompt actor unavailable. r=johannh!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/822ff34d6e5c
Prompter.jsm: Fallback to window prompts if prompt actor unavailable. r=johannh

Comment 5

[Paul Zühlcke [:pbz]]

Attachment: Bug 1631171 - Prompter.jsm openWindowPrompt: Fixed fallback to active window when null is passed. r=gijs!

Depends on D71524

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/081fc3dae3bb
Prompter.jsm openWindowPrompt: Fixed fallback to active window when null is passed. r=Gijs

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/822ff34d6e5c
https://hg.mozilla.org/mozilla-central/rev/081fc3dae3bb

Comment 8

[Alin Ilea]

Reproduced the initial issue using Nightly build 77.0a1 (build id: 20200417100143).
Verified - Fixed in Beta 77.0b3 (build id: 20200507233245) and latest Nightly 78.0a1 (build id: 20200507085231) on Windows 10.