1631272 - Cleanup Stencil data structures

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

Here is a series of patches to bring the Stencil data structures closer to their final form. This includes removing redundant fields and organizing more similar to BaseScript.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1631272 - Remove immutableScriptData argument of ScriptStencil constructor. r?mgaudet

Move the argument to the init methods of the sub-classes instead. This lets
us initialize the fields of the stencil in one place.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1631272 - Organize the ScriptStencil fields. r?mgaudet

Organize fields to better reflect the BaseScript layout. Also remove the
ngthings field which is redundant. Add override keyword for virtual methods
for safety.

Depends on D71472

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1631272 - Remove redundant FunctionCreationData fields. r?mgaudet

The isSelfHosting, kind, and allocKind fields should be directly encoded into
the FunctionFlags.

Depends on D71473

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1631272 - Remove FunctionCreationData::generatorKind/asyncKind. r?mgaudet

Instead, encode them as ImmutableScriptFlags. The sets up to later combine
the FunctionCreationData with the ScriptStencil.

Depends on D71474

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f0c8cf76eff
Remove immutableScriptData argument of ScriptStencil constructor. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/000589fb60ee
Organize the ScriptStencil fields. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/c19316d62320
Remove redundant FunctionCreationData fields. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/9ac3134f48af
Remove FunctionCreationData::generatorKind/asyncKind. r=mgaudet

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6f0c8cf76eff
https://hg.mozilla.org/mozilla-central/rev/000589fb60ee
https://hg.mozilla.org/mozilla-central/rev/c19316d62320
https://hg.mozilla.org/mozilla-central/rev/9ac3134f48af