1631281 - If "Open tabs" suggestion is disabled, top sites in address bar doesn't show open top sites

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Asif Youssuff]

Attachment: 8xxnzpbmnpt41.jpg

From: https://www.reddit.com/r/firefox/comments/g42asi/when_disabling_switch_to_tab_feature_on_address/

Steps to reproduce:

1. Ensure YouTube is in top sites
2. Open YouTube
3. Ensure "Open tabs" suggestion is disabled for address bar
4. open new tab, navigate to any other site
5. Click on address bar

What happens:

YouTube doesn't appear in the top sites suggestions in the address bar.

Expected result:

YouTube appears; clicking the suggestion opens it without switching to existing tab.

Comment 1

[Michael Kohler [:mkohler]]

This is interesting given the use case in the reddit post. However, personally, I'd probably argue that a user who doesn't want open tabs to show up, also doesn't want it to show up if it's a top site.

FWIW, here's the corresponding code: https://searchfox.org/mozilla-central/rev/a4d62e09a4c46aef918667fa759bf9ae898dc258/browser/components/urlbar/UrlbarProviderTopSites.jsm#146

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

We handle it differently, for open tabs we just don't show them as open tabs (provided they are in history or bookmarks), being open doesn't influence frecency.
Based on our current handling this is a bug.

Comment 3

[Harry Twyford]

Attachment: Bug 1631281 - Show Top Sites regardless of suggest.openpage and suggest.bookmark pref values. r?adw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c523474446e
Show Top Sites regardless of suggest.openpage and suggest.bookmark pref values. r=adw

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4c523474446e

Comment 6

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I verified this issue using Fx 77.0a1 (2020-04-30) on Windows 10 x64 and macOS 10.13.