1631386 - Check OOM handling in MediaTransportHandlerSTS::GetIceLog

Status: REOPENED

(Core :: WebRTC: Signaling, task, P3)

Description

[Simon Giesecke [:sg] [he/him]]

Bug 1628715 identified that the return value of a fallible call to nsTArray::AppendElement was discarded. It was changed to crash in this case for the time being. It should be checked if a different error handling should be done here.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=63e0793edd31d84f24ad8c9289740ab4514b46c6

Comment 2

[Simon Giesecke [:sg] [he/him]]

Actually, it would be preferrable to call SetCapacity once outside the loop, since the number of elements which will be added is known. This avoids repeated reallocations of the array, and ensures that there can't be a failure within the loop.

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1631386 - Check for OOM when grabbing the ICE logs;r?bwc

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ng, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Simon Giesecke [:sg] [he/him]]

I think this was resolved as a duplicate (of the bug it was spawned from) accidentally. Shouldn't the patch attached just land?

Comment 7

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Yes, thanks Simon, this was indeed closed by mistake. Though, the patch shouldn't land as written.