1631403 - Add an explicit test case to cover the Remote Debugging Protocol APIs that "web-ext run" depends on

Status: RESOLVED FIXED

(WebExtensions :: Developer Tools, task, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

web-ext does use the Remote Debugging Protocol to install an extension temporarily on a Firefox instance.

As code that depends on mozilla-central code but developed outside of mozilla-central, it is not unlikely that changes (e.g. a refactoring) happening on mozilla-central on the DevTools server code may introduce a regression that breaks web-ext run and we may miss to notice that as soon as the change lands in mozilla-central (e.g. see mozilla/web-ext#1884 for a recent example).

As Julian did mention in his comment on mozilla/web-ext#1884, we should add a small test in m-c to check that the APIs you use (in particular: getRoot, addonsActor.installTemporaryAddon, listAddons and addons.reload) are still working as expected (and webext peers as blocking reviewers for any change on it).

See https://github.com/mozilla/web-ext/blob/master/src/firefox/remote.js for the Remote Debugging Protocol requests that web-ext run depends on.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

I'm setting the priority to P3 and assigning this issue to :willdurand, as he told me that he would like to work on this.

Comment 2

[William Durand [:willdurand]]

Attachment: Bug 1631403 - Add test case to cover RDP APIs that 'web-ext run' depends on. r=rpl,ochameau,robwu

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78f47bf43523
Add test case to cover RDP APIs that 'web-ext run' depends on. r=rpl,ochameau

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing xpcshell at test_webext_apis.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=298879052&resultStatus=testfailed%2Cbusted%2Cexception&revision=78f47bf435233a728f49abf3eae68fd17f45e8ba

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298879052&repo=autoland&lineNumber=1145
Tier1: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298886611&repo=autoland&lineNumber=8561

Backout: https://hg.mozilla.org/integration/autoland/rev/4f2b143094781660661ef959a1ea66f0565c5c84

Comment 5

[William Durand [:willdurand]]

Sorry about that, the added test case had a weak condition at the end, making it unreliable. I updated the revision with a better approach to fix this and it looks better now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f34b8656ef707ed260722a2df21bedd895e09c1d

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe4e3650f011
Add test case to cover RDP APIs that 'web-ext run' depends on. r=rpl,ochameau,robwu

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/fe4e3650f011

Comment 8

[Andreea Pavel [:apavel]]

(In reply to William Durand [:willdurand] from comment #5)

Sorry about that, the added test case had a weak condition at the end, making it unreliable. I updated the revision with a better approach to fix this and it looks better now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f34b8656ef707ed260722a2df21bedd895e09c1d

No problem, thanks for the fix!