1631435 - IPDL: Resolver argument should be value or rvalue-reference, not a const reference

Status: NEW

(Core :: IPC, defect, P5)

Description

[Simon Giesecke [:sg] [he/him]]

Resolver arguments are generated as const&, but are moved afterwards, such that the move has no effect.

E.g. in https://searchfox.org/mozilla-central/source/__GENERATED__/ipc/ipdl/PMediaTransportParent.cpp#364

           GetIceLogResolver resolver = [this, self__, id__, seqno__](const WebrtcGlobalLog& aParam) {

and then in https://searchfox.org/mozilla-central/source/__GENERATED__/ipc/ipdl/PMediaTransportParent.cpp#371:

                loglines = std::move(aParam);

This is particularly unfortunate when aParam's type contains a FallibleTArray, which ought to be made non-copyable by Bug 1628692.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jld, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jld, could you have a look please?

For more information, please visit auto_nag documentation.