1631437 - Authentication method not updated for selected SMTP server in Account Settings

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Peter Keresztes Schmidt]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Open "Outgoing Server (SMTP)" and select a server.

Actual results:

Authentication method in details pane remains empty.

Console shows following message:

TypeError: document.getElementById(...) is null 4 am-smtp.js:184:12
updateServerInfoBox chrome://messenger/content/am-smtp.js:184
onSelectionChanged chrome://messenger/content/am-smtp.js:47
onselect chrome://messenger/content/am-smtp.xul:1
_fireOnSelect chrome://global/content/elements/richlistbox.js:332
selectItem chrome://global/content/elements/richlistbox.js:463
onxblmousedown chrome://global/content/bindings/richlistbox.xml:125
MsgAccountManager chrome://messenger/content/accountUtils.js:290
oncommand chrome://messenger/content/messenger.xul:1

Expected results:

Authentication method should be displayed.

Comment 1

[Magnus Melin [:mkmelin]]

WFM on trunk.

Comment 2

[Peter Keresztes Schmidt]

Trunk has commented out the failing code. See https://github.com/mozilla/releases-comm-central/commit/f86746da336942adc03b5fec7ead429627f17e29#diff-6676100a77117f1ce51f8da04b34e5c8R181

On released 68.7 it is definitely failing with the above mentioned stack trace.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: bug1631437_smtp_auth.patch

I think this was left in the wrong place in bug 1538409. Then bug 1610445 commented it out...

Comment 4

[Khushil Mistry [:khushil324]]

Do we also need a patch for ESR68 also?

Comment 5

[Magnus Melin [:mkmelin]]

Yes, I can take care of that, it's just removing the part that was commented on trunk.

Comment 6

[Khushil Mistry [:khushil324]]

Comment on attachment 9143718 [details] [diff] [review]
bug1631437_smtp_auth.patch

Review of attachment 9143718 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good. r=khushil

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ed17a22ae3d9
fix display of smtp authentication method. r=khushil

Comment 8

[Magnus Melin [:mkmelin]]

We should uplift to 68. It's a regression from another uplift (bug 1538409)

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: bug1631437_smtp_auth-ESR68.patch

For ESR.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9143914 [details] [diff] [review]
bug1631437_smtp_auth-ESR68.patch

Good in beta, so approved for ESR

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 68.8.0:
https://hg.mozilla.org/releases/comm-esr68/rev/522380f8a79e