Authentication method not updated for selected SMTP server in Account Settings
Categories
(Thunderbird :: Account Manager, defect)
Tracking
(thunderbird_esr68+ fixed)
People
(Reporter: carbenium, Assigned: mkmelin)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
3.39 KB,
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
3.17 KB,
patch
|
wsmwk
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0
Steps to reproduce:
Open "Outgoing Server (SMTP)" and select a server.
Actual results:
Authentication method in details pane remains empty.
Console shows following message:
TypeError: document.getElementById(...) is null 4 am-smtp.js:184:12
updateServerInfoBox chrome://messenger/content/am-smtp.js:184
onSelectionChanged chrome://messenger/content/am-smtp.js:47
onselect chrome://messenger/content/am-smtp.xul:1
_fireOnSelect chrome://global/content/elements/richlistbox.js:332
selectItem chrome://global/content/elements/richlistbox.js:463
onxblmousedown chrome://global/content/bindings/richlistbox.xml:125
MsgAccountManager chrome://messenger/content/accountUtils.js:290
oncommand chrome://messenger/content/messenger.xul:1
Expected results:
Authentication method should be displayed.
Assignee | ||
Comment 1•10 months ago
|
||
WFM on trunk.
Reporter | ||
Comment 2•10 months ago
|
||
Trunk has commented out the failing code. See https://github.com/mozilla/releases-comm-central/commit/f86746da336942adc03b5fec7ead429627f17e29#diff-6676100a77117f1ce51f8da04b34e5c8R181
On released 68.7 it is definitely failing with the above mentioned stack trace.
Assignee | ||
Comment 3•10 months ago
|
||
I think this was left in the wrong place in bug 1538409. Then bug 1610445 commented it out...
Comment 4•10 months ago
|
||
Do we also need a patch for ESR68 also?
Assignee | ||
Comment 5•10 months ago
|
||
Yes, I can take care of that, it's just removing the part that was commented on trunk.
Comment 6•10 months ago
|
||
Comment on attachment 9143718 [details] [diff] [review] bug1631437_smtp_auth.patch Review of attachment 9143718 [details] [diff] [review]: ----------------------------------------------------------------- Changes look good. r=khushil
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/ed17a22ae3d9
fix display of smtp authentication method. r=khushil
Assignee | ||
Comment 8•10 months ago
|
||
We should uplift to 68. It's a regression from another uplift (bug 1538409)
Comment 10•10 months ago
|
||
Comment on attachment 9143914 [details] [diff] [review] bug1631437_smtp_auth-ESR68.patch Good in beta, so approved for ESR
Comment 11•10 months ago
|
||
bugherderuplift |
Thunderbird 68.8.0:
https://hg.mozilla.org/releases/comm-esr68/rev/522380f8a79e
Updated•9 months ago
|
Description
•