1631465 - Expose per-printer the non-writable paper areas to the frontend code

Status: RESOLVED FIXED

(Core :: Print Preview, enhancement, P2)

Description

[Jonathan Watt [:jwatt]]

The new print preview design [still] allows the paper margins to be given user supplied values. We do not have a way to inform the frontend code about the physical limitations of the selected printer however. We should implement a mechanism to do that so that the preview can be prevented from displaying the pages with smaller margins than the selected printer is capable of printing. Without that the preview could end up looking fine but the actual print could end up clipping what was shown in the print preview which would be frutrating.

Comment 2

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1631465 part 1 - Add unwritable margin information to nsIPaper

Comment 3

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1631465 part 2 - Add unwritable margin information for OS X

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fcf60c39b09
part 1 - Add unwritable margin information to nsIPaper r=jwatt
https://hg.mozilla.org/integration/autoland/rev/cc31df5b2aca
part 2 - Add unwritable margin information for OS X r=jwatt

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4fcf60c39b09
https://hg.mozilla.org/mozilla-central/rev/cc31df5b2aca

Comment 6

[Bob Owen (:bobowen)]

Try push for adding to Windows with refactoring to get things lazily:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedTaskRun=caQX4wklQr-AV2jadguK_A.0&revision=64093a1d028eb3e01870fdc3a55f668628ccbdb1

Comment 7

[Bob Owen (:bobowen)]

Attachment: Bug 1631465 part 3: Move calculation of unwritable margins to WinUtils. r=jwatt!

At some point it might be good to move all of the interaction with the native
Windows printer API into some sort of wrapper class, but this keeps it simple
for now.

Comment 8

[Bob Owen (:bobowen)]

Attachment: Bug 1631465 part 4: Add unwritable margin information for Windows. r=jwatt!

This includes adding nsPrinterWin and nsPaperWin, so that we can retrieve
information from the printer device lazily.

Depends on D84008

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2870d4d0abb9
part 3: Move calculation of unwritable margins to WinUtils. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/28c7e80eab2f
part 4: Add unwritable margin information for Windows. r=jwatt

Comment 10

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2870d4d0abb9
https://hg.mozilla.org/mozilla-central/rev/28c7e80eab2f