about:networking "categories" list <hr> is impossible to see, and so just creates a subtle odd-looking gap
Categories
(Firefox :: Theme, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: dholbert, Assigned: aarushivij, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(2 files)
STR:
- Visit
about:networking
- Look at the left "categories" list, between "WebSockets" and "DNS Lookup"
ACTUAL RESULTS:
There's an odd gap.
EXPECTED RESULTS:
There should (maybe?) be a visible horizontal rule there, to separate sections. If I look at the page DOM in devtools, I can see there's a hr
element, but its color is nearly-transparent white, which is imperceptible on top of the page's light-gray background.
(Alternately: maybe the hr should be legitimately transparent, rather than almost-but-not-quite-transparent?)
Searchfox link for the styling in question (which makes this hr
invisible):
https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/toolkit/themes/shared/aboutNetworking.css#44
Looks like this styling dates back to bugs 1246498 (which just tweaked some styling that was added in bug 1242073).
ntim, maybe you could take a look? Do you know if this hr was intended to be more visible?
Reporter | ||
Comment 1•4 years ago
|
||
Reporter | ||
Comment 2•4 years ago
|
||
On the other hand: if this look is in fact what we want, then we can achieve it more declaratively by changing
border-top-color: rgba(255,255,255,0.15);
...to use transparent
as the color (instead of the current nearly-but-not-quite-transparent, effectively-imperceptible-but-still-there color).
Comment 3•4 years ago
|
||
The rgba(255,255,255,0.15)
color made sense when we had the dark blue category background. The categories have since been redesigned to not have a background with Photon.
The original intent was to have a visible separator, but this is broken now.
Those rules should just be deleted, so the default common.css hr
styling can apply:
https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/browser/components/enterprisepolicies/content/aboutPolicies.css#35-38
https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/toolkit/themes/shared/aboutNetworking.css#43-46
https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/toolkit/themes/mobile/global/aboutNetworking.css#41-44
Assignee | ||
Comment 4•4 years ago
|
||
Hello, Can I take up this issue?
Thanks :)
Assignee | ||
Updated•4 years ago
|
Comment 5•4 years ago
|
||
(In reply to aarushivij from comment #4)
Hello, Can I take up this issue?
Thanks :)
Yes, please go ahead :)
Assignee | ||
Comment 6•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/190c19f63256 Remove outdated `#categories hr` styling. r=ntim
Comment 8•4 years ago
|
||
bugherder |
Description
•