Closed Bug 1631501 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23119 - Fix inline box positions when RTL and has trailing spaces

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23119 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23119
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

Fix inline box positions when RTL and has trailing spaces

This patch fixes inline box positions when the line is in RTL
and has preserved trailing spaces.

There are two issues for this combination:
a. Computes incorrect value for how much the line hangs.
b. When hang is not zero, inline box positions are incorrect.

This patch fixes the issue b.

The issue a is related but does not contribute to the
reported symptom. It should be worked with better trailing
space support and UAX#9 L1 support (crbug.com/316409). TODO
comment added for this issue.

Bug: 1062716
Change-Id: Ie33db517ebc886a724116b594699f8d59751c808

Reviewed-on: https://chromium-review.googlesource.com/2156235
WPT-Export-Revision: cb2f86e48f1384e85f7f64000a7127436062d056

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46d259f127e1
[wpt PR 23119] - Fix inline box positions when RTL and has trailing spaces, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/07304516644e
[wpt PR 23119] - Fix inline box positions when RTL and has trailing spaces, a=testonly

https://hg.mozilla.org/mozilla-central/rev/07304516644e

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.