1631506 - Missing fields in telemetry.crash

Status: RESOLVED FIXED

(Data Platform and Tools :: General, defect, P2)

Description

[William Lachance (:wlach)]

https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/toolkit/crashreporter/CrashAnnotations.yaml#126

It appears this crash annotation was added in bug 1587721, but we never added it to the crash schemas so it went straight to additional properties. We should put it somewhere in here:

https://github.com/mozilla-services/mozilla-pipeline-schemas/blob/master/schemas/telemetry/crash/crash.4.schema.json

We should also add a note about it here:

https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/toolkit/components/telemetry/docs/data/crash-ping.rst#53

Comment 1

[William Lachance (:wlach)]

Let's add PurgeablePhysicalMemory while we're at it (thanks Anna for noticing): https://bugzilla.mozilla.org/show_bug.cgi?id=1635212#c3

Comment 2

[William Lachance (:wlach)]

Did an audit and there were even more fields missing. I wrote up a quick script to parse the CrashAnnotations file from mozilla-central:

https://hg.mozilla.org/mozilla-central/raw-file/tip/toolkit/crashreporter/CrashAnnotations.yaml

Will file a PR shortly.

Ideally we'd have some sort of more principled approach to getting these annotations added but I guess at least this will take some of the chore out.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla-services/mozilla-pipeline-schemas/pull/546

Comment 4

[William Lachance (:wlach)]

Filed bug 1637311 about automating this better somehow in the future.