Closed Bug 1631526 Opened 4 years ago Closed 4 years ago

Create a firefox-pkg-latest-ssl product with os of osx and variable language

Categories

(Cloud Services :: Operations: Bouncer, task)

Product:
Cloud Services
Component:
Operations: Bouncer
Type:
task

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: Callek, Assigned: oremj)

References

Details

So, we have a request in Bug 1617992 to create and utilize a new product for osx package format.

It would mirror the firefox-latest-ssl settings but only be for osx (similar in setup to the -msi stuff we did)

For placeholder entry on bouncer we can use https://download-installer.cdn.mozilla.net/pub/firefox/releases/75.0/mac/%LANG%/Firefox%2075.0.pkg since the .pkg is alongside the .dmg files on the releases.

So more specifically we will want this for the product on multiple branches:

  • firefox-esr-next-pkg-latest-ssl
  • firefox-esr-pkg-latest-ssl
  • firefox-devedition-pkg-latest-ssl
  • firefox-beta-pkg-latest-ssl
  • firefox-pkg-latest-ssl

Any questions, myself, nick or mkaply can probably assist.

Assignee: oremj → mtabara

Turns out we still need a few amendments in bouncer from the admin side, otherwise automation will fail. These need to be updated in both existing bouncer tuxedo and Nazgul.

We need to create two products:
i) firefox-nightly-pkg-latest-ssl with just one location, for osx to point to /firefox/nightly/latest-mozilla-central-l10n/firefox-77.0a1.:lang.mac.pkg
ii) firefox-nightly-pkg-latest-l10n-ssl with just one location, for osx to point to /firefox/nightly/latest-mozilla-central-l10n/firefox-77.0a1.:lang.mac.pkg

This is needed for the bouncer-locations jobs on central. For bouncer submission and aliases, API creates where it cannot update so we're good.

Flags: needinfo?(oremj)

Sounds good. I might not be able to check this out until tomorrow.

Does this look correct?

curl -d 'product=firefox-nightly-pkg-latest-ssl&ssl_only=true' https://HOST/api/product_add/
curl -d 'product=firefox-nightly-pkg-latest-ssl&os=osx&path=/firefox/nightly/latest-mozilla-central-l10n/firefox-77.0a1.:lang.mac.pkg' https://HOST/api/location_add/

curl -d 'product=firefox-nightly-pkg-latest-l10n-ssl&ssl_only=true' https://HOST/api/product_add/
curl -d 'product=firefox-nightly-pkg-latest-l10n-ssl&os=osx&path=/firefox/nightly/latest-mozilla-central-l10n/firefox-77.0a1.:lang.mac.pkg' https://HOST/api/location_add/
Flags: needinfo?(oremj) → needinfo?(mtabara)

I slipped a typo in there, mea culpa. the firefox-nightly-pkg-latest-ssl should point to the en-US bucket:

curl -d 'product=firefox-nightly-pkg-latest-ssl&ssl_only=true' https://HOST/api/product_add/
curl -d 'product=firefox-nightly-pkg-latest-ssl&os=osx&path=/firefox/nightly/latest-mozilla-central/firefox-77.0a1.:lang.mac.pkg' https://HOST/api/location_add/

The second one for l10n is correct.

curl -d 'product=firefox-nightly-pkg-latest-l10n-ssl&ssl_only=true' https://HOST/api/product_add/
curl -d 'product=firefox-nightly-pkg-latest-l10n-ssl&os=osx&path=/firefox/nightly/latest-mozilla-central-l10n/firefox-77.0a1.:lang.mac.pkg' https://HOST/api/location_add/
Flags: needinfo?(mtabara)
Assignee: mtabara → oremj

Nazgul:

# curl  -d 'product=firefox-nightly-pkg-latest-ssl&ssl_only=true' http://localhost/api/product_add/
<?xml version="1.0" encoding="utf-8"?><products><product id="15039" name="firefox-nightly-pkg-latest-ssl"/></products>

# curl http://localhost/api/location_add/
<?xml version="1.0" encoding="utf-8"?><locations><product id="15039" name="firefox-nightly-pkg-latest-ssl"><location id="70938" os="osx">/firefox/nightly/latest-mozilla-central/firefox-77.0a1.:lang.mac.pkg</location></product></locations>

# curl -d product=firefox-nightly-pkg-latest-l10n-ssl&ssl_only=true http://localhost/api/product_add/
<?xml version="1.0" encoding="utf-8"?><products><product id="15040" name="firefox-nightly-pkg-latest-l10n-ssl"/></products>

curl -d product=firefox-nightly-pkg-latest-l10n-ssl&os=osx&path=/firefox/nightly/latest-mozilla-central-l10n/firefox-77.0a1.:lang.mac.pkg http://localhost/api/location_add/
<?xml version="1.0" encoding="utf-8"?><locations><product id="15040" name="firefox-nightly-pkg-latest-l10n-ssl"><location id="70939" os="osx">/firefox/nightly/latest-mozilla-central-l10n/firefox-77.0a1.:lang.mac.pkg</location></product></locations>[root@ip-172-31-16-33 ~]#

Tuxedo:

$ curl -u $USERNAME:$PASSWORD -d 'product=firefox-nightly-pkg-latest-ssl&ssl_only=true' http://localhost:81/api/product_add/
<?xml version="1.0" encoding="utf-8"?><products><product id="15102" name="firefox-nightly-pkg-latest-ssl"/></products>

$ curl -u $USERNAME:$PASSWORD -d 'product=firefox-nightly-pkg-latest-ssl&os=osx&path=/firefox/nightly/latest-mozilla-central/firefox-77.0a1.:lang.mac.pkg' http://localhost:81/api/location_add/
<?xml version="1.0" encoding="utf-8"?><locations><product id="15102" name="firefox-nightly-pkg-latest-ssl"><location id="71300" os="osx">/firefox/nightly/latest-mozilla-central/firefox-77.0a1.:lang.mac.pkg</location></product></locations>

$ curl -u $USERNAME:$PASSWORD -d 'product=firefox-nightly-pkg-latest-l10n-ssl&ssl_only=true' http://localhost:81/api/product_add/
<?xml version="1.0" encoding="utf-8"?><products><product id="15103" name="firefox-nightly-pkg-latest-l10n-ssl"/></products>

$ curl -u $USERNAME:$PASSWORD -d 'product=firefox-nightly-pkg-latestcation_add/s=osx&path=/firefox/nightly/latest-mozilla-central-l10n/firefox-77.0a1.:lang.mac.pkg' http://localhost:81/api/lo
<?xml version="1.0" encoding="utf-8"?><locations><product id="15103" name="firefox-nightly-pkg-latest-l10n-ssl"><location id="71301" os="osx">/firefox/nightly/latest-mozilla-central-l10n/firefox-77.0a1.:lang.mac.pkg</location></product></locations>
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Why do these only work with nightly? Aren't bouncer links generic?

(In reply to Mike Kaply [:mkaply] from comment #8)

Why do these only work with nightly? Aren't bouncer links generic?

We have dedicated product "aliases" for nightly/beta and release. The patches that I've landed add support for all of them. For beta/release automation can automatically create if not exists in bouncer, whereas for nightlies we had to manually create them beforehand so that our automation doesn't complain. It's just an implementation detail on our side + some limitation in how bouncer was set up for the nightly locations years ago.

The leftovers steps are https://bugzilla.mozilla.org/show_bug.cgi?id=1617992#c18 - nightly will be fully functional by EOD, beta and release as we go forward, once my patches get uplifted. If we want these avertised sooner than the next release, we can adjust the bouncer side manually or wait until the next dot release.

Next dot release should be fine. I was just curious. Thanks!

Turns out I had yet-another typo in my logic, the en-US one was not supposed to have :lang but en-US in it.
@oremj, can you please update the en-US entries for both Tuxedo and Nazgul with the following to unblock automation?

Nazgul:

curl -d `product=firefox-nightly-pkg-latest-ssl&os=osx&path=/firefox/nightly/latest-mozilla-central/firefox-77.0a1.en-US.mac.pkg` http://localhost/api/location_modify/

Tuxedo:

$ curl -u $USERNAME:$PASSWORD -d 'product=firefox-nightly-pkg-latest-ssl&os=osx&path=/firefox/nightly/latest-mozilla-central/firefox-77.0a1.en-US.mac.pkg' http://localhost:81/api/location_modify/
Status: VERIFIED → REOPENED
Flags: needinfo?(oremj)
Resolution: FIXED → ---

Tuxedo

$ curl -u $USERNAME:$PASSWORD -d 'product=firefox-nightly-pkg-latest-ssl&os=osx&path=/firefox/nightly/latest-mozilla-central/firefox-77.0a1.en-US.mac.pkg' http://localhost:81/api/location_modify/
<?xml version="1.0" encoding="utf-8"?><locations><product id="15102" name="firefox-nightly-pkg-latest-ssl"><location id="71300" os="osx">/firefox/nightly/latest-mozilla-central/firefox-77.0a1.en-US.mac.pkg</location></product></locations>

Nazgul

# curl -u $USERNAME:$PASSWORD -d 'product=firefox-nightly-pkg-latest-ssl&os=osx&path=/firefox/nightly/latest-mozilla-central/firefox-77.0a1.en-US.mac.pkg' http://localhost/api/location_modify/
<?xml version="1.0" encoding="utf-8"?><locations><product id="15039" name="firefox-nightly-pkg-latest-ssl"><location id="70938" os="osx">/firefox/nightly/latest-mozilla-central/firefox-77.0a1.en-US.mac.pkg</location></product></locations>
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Flags: needinfo?(oremj)
Resolution: --- → FIXED

Both bouncer-locations jobs are green now. See legacy and nazgul.

Thanks for fixing these.

Status: RESOLVED → VERIFIED
See Also: → 1785143
You need to log in before you can comment on or make changes to this bug.