Closed Bug 1631539 Opened 3 months ago Closed 2 months ago

Update SeaMonkey website for 2.53.2 Final release

Categories

(SeaMonkey :: Website, task)

SeaMonkey 2.53 Branch

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This is the bug for any website changes needed for the 2.53.2 final release

Attached patch 2.53.2 website patch (obsolete) — Splinter Review

Extra changes may still be needed for news item and release notes.

Attachment #9141829 - Flags: review?(frgrahl)
Attachment #9141829 - Flags: feedback?(rsx11m.pub)
Attachment #9141829 - Flags: feedback?(rpmdisguise-nave)
Attachment #9141829 - Flags: feedback?(ewong)
Comment on attachment 9141829 [details] [diff] [review]
2.53.2 website patch

Review of attachment 9141829 [details] [diff] [review]:
-----------------------------------------------------------------

All OK for me, except line 16 in sitemap.xml:

<page url="releases/2.53.2" title="2.53.2" id="2.53.1" hide="false">

The id tag should read id="2.53.2".
Attachment #9141829 - Flags: feedback?(rpmdisguise-nave) → feedback+

(In reply to RickieES aka Ricardo Palomares from comment #2)

Comment on attachment 9141829 [details] [diff] [review]
2.53.2 website patch

Review of attachment 9141829 [details] [diff] [review]:

All OK for me, except line 16 in sitemap.xml:

<page url="releases/2.53.2" title="2.53.2" id="2.53.1" hide="false">

The id tag should read id="2.53.2".

Thanks, patch updated locally.

Comment on attachment 9141829 [details] [diff] [review]
2.53.2 website patch

src/news.en.xml

> 2.53.2 is an incremental from the 2.53.x branch and 

word "update" missing?

> Automatic upgrades from previous versions
> +are, for most configurations, disabled for this release.

"for most configurations" should be dropped I think. Updates are currently non functional.

r+ with nits fixed or answered.
Attachment #9141829 - Flags: review?(frgrahl) → review+

(In reply to Frank-Rainer Grahl (:frg) from comment #4)

Comment on attachment 9141829 [details] [diff] [review]
2.53.2 website patch

src/news.en.xml

2.53.2 is an incremental from the 2.53.x branch and

word "update" missing?

Automatic upgrades from previous versions
+are, for most configurations, disabled for this release.

"for most configurations" should be dropped I think. Updates are currently
non functional.

r+ with nits fixed or answered.

Updated locally.

As I've made a couple more changes I thought I'd put a new version of the website patch up but do we want to add anything about the patches that have landed since beta 1?
Potentially one is the mail links in a private window, but are there others too?

Attachment #9141829 - Attachment is obsolete: true
Attachment #9141829 - Flags: feedback?(rsx11m.pub)
Attachment #9141829 - Flags: feedback?(ewong)
Attachment #9143495 - Flags: review?(frgrahl)
Attachment #9143495 - Flags: feedback?(rsx11m.pub)
Attachment #9143495 - Flags: feedback?(ewong)
Comment on attachment 9143495 [details] [diff] [review]
2.53.2 website patch v1.1 [Checked in: Comment 11]

Basically fine.

Compared to Beta 1 these critical security flaws were close:
https://www.mozilla.org/en-US/security/advisories/mfsa2020-11/

Also a few crasher and minor security fixes were done bringing it more up to day. We maybe should mention the sec advisory. Mentioning the private open link would be fine too but we didn't mention all more minor changes even in the Beta.
Attachment #9143495 - Flags: review?(frgrahl) → review+
Comment on attachment 9143495 [details] [diff] [review]
2.53.2 website patch v1.1 [Checked in: Comment 11]

Looks ok.
Attachment #9143495 - Flags: feedback?(rsx11m.pub) → feedback+
Comment on attachment 9143495 [details] [diff] [review]
2.53.2 website patch v1.1 [Checked in: Comment 11]

Review of attachment 9143495 [details] [diff] [review]:
-----------------------------------------------------------------

I"m not familiar with XML::Simple() and looking at the documentation,  its use is discouraged.  That said, I'm seriously hoping to do away with perl and figure something else.

::: src/start/index.en.html
@@ +137,5 @@
>  [% INCLUDE downloads_fieldset %]
>  </div>
>  <div style="display: none;">
>  [% USE languages = XML::Simple(
> +       'downloads_table_2532.en.xml'

Pardon my ignorance, but where is this file from?  More so, what does it do?
Attachment #9143495 - Flags: feedback?(ewong) → feedback+

(In reply to Edmund Wong (:ewong) from comment #9)

Comment on attachment 9143495 [details] [diff] [review]
2.53.2 website patch v1.1

<div style="display: none;">
[% USE languages = XML::Simple(

  •   'downloads_table_2532.en.xml'
    

Pardon my ignorance, but where is this file from? More so, what does it do?

The file is stored under lib/ and contains information for what needs to go into the downloads table / downloads dropdown

Comment on attachment 9143495 [details] [diff] [review]
2.53.2 website patch v1.1 [Checked in: Comment 11]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/2b22ca5178ba297e122ef02150f1c84500288da9
https://gitlab.com/seamonkey-project/website/-/commit/e9383b1838ed5fd77c807bb51cccd62daaf17ded
Attachment #9143495 - Attachment description: 2.53.2 website patch v1.1 → 2.53.2 website patch v1.1 [Checked in: Comment 11]
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.