Closed Bug 1631601 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23125 - [css-logical] Include logical properties when iterating a computed style

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23125 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23125
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-logical] Include logical properties when iterating a computed style

The logical properties were not added into kComputedPropertyArray, so
they were skipped when iterating a computed CSSStyleDeclaration like
[...getComputedStyle(document.body)].

BUG=1072180

TEST=external/wpt/css/css-logical/getComputedStyle-listing.html
TEST=external/wpt/css/cssom/cssstyledeclaration-csstext.html
TEST=external/wpt/css/cssom/cssstyledeclaration-custom-properties.html
TEST=fast/css/getComputedStyle/computed-style-listing.html
TEST=fast/css/getComputedStyle/computed-style-without-renderer-listing.html
TEST=svg/css/getComputedStyle-listing.html

Change-Id: Ia83ac8608b2b98601f454653900e76f89291b4aa

Reviewed-on: https://chromium-review.googlesource.com/2153442
WPT-Export-Revision: 89d173e67411ef0280e409065c825543ff927f2a

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 60 tests

Status Summary

Firefox

OK : 1
PASS: 30[GitHub] 89[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 1
FAIL: 30

Safari

OK : 1
FAIL: 30

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/189c0e5e25dc
[wpt PR 23125] - [css-logical] Include logical properties when iterating a computed style, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/a541c061c4fb
[wpt PR 23125] - [css-logical] Include logical properties when iterating a computed style, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a541c061c4fb

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.