Allow fast Ion-to-Wasm calls for functions with I64 stack arguments
Categories
(Core :: JavaScript: WebAssembly, task, P3)
Tracking
()
People
(Reporter: asumu, Unassigned)
References
(Blocks 1 open bug)
Details
Patches for bug 1608771 make Ion to Wasm calls with BigInt/I64 arguments fast in most cases, but does not optimize calls in which there are I64 arguments that get assigned to the stack.
This bug report documents this limitation, which is due to a check that the register allocator makes to ensure at-start call uses with same type temps are not allowed: https://searchfox.org/mozilla-central/source/js/src/jit/BacktrackingAllocator.cpp#701 (I64 uses have LDefinition::General kind, which is the same as temps)
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Comment 1•4 years ago
|
||
Optimization item, bumping to P3.
|
|
||
Comment 2•3 years ago
|
||
I think we should still get the jit-entry here so this does not seem critical, it's not like we're forced back to the interpreter entry.
|
|
||
Comment 3•3 years ago
|
||
Yury mentions that this might become more interesting with memory64, which will make 64-bit data more common.
Description
•