1631776 - Another round of ImageDocument cleanup.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1631776 - Convert some imagedocument prefs to static prefs. r=smaug

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1631776 - Always reset image zoom to 100%. r=smaug

This effectively already happens on Firefox.

Android doesn't use full zoom so this is also shouldn't affect it, and it seems
reasonable behavior.

Depends on D71753

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1631776 - Miscellaneous cleanups on ImageDocument. r=smaug

The comment no longer made any sense, and IgnoreErrors() is nicer than
manually doing so.

Depends on D71754

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1631776 - Use IsTopLevelContentDocument() instead of nsContentUtils::IsChildOfSameType on ImageDocument. r=smaug

It's what it wants, really.

Depends on D71755

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1631776 - Remove ImageDocument.restoreImageTo. r=smaug

Unused except for one caller that can just be inlined.

Depends on D71756

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1631776 - Track less state about overflow in ImageDocument. r=smaug

The overflow can be inferred from other variables.

Depends on D71757

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1631776 - Store an HTMLImageElement in ImageDocument. r=smaug

Saves a few QIs and such.

Depends on D71758

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1631776 - Unifdef ImageDocument's resolution logic. r=botond

This was copy-pasta from the full-zoom code I'm changing in other patches in
this bug. However this code seems slightly more wrong: if mOriginalResolution
was somehow not 1.0, it seems to me like the right behavior would be to allow
resizing the image if the user zooms out. This patch allows that, and is
simpler, and not android-specific.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/248a7a6c782e
Convert some imagedocument prefs to static prefs. r=smaug

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc6e3f356b0d
Miscellaneous cleanups on ImageDocument. r=smaug
https://hg.mozilla.org/integration/autoland/rev/2f88dd16b396
Remove ImageDocument.restoreImageTo. r=smaug
https://hg.mozilla.org/integration/autoland/rev/b6f193afd449
Track less state about overflow in ImageDocument. r=smaug
https://hg.mozilla.org/integration/autoland/rev/6da46fc6472c
Store an HTMLImageElement in ImageDocument. r=smaug

Comment 11

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/248a7a6c782e
https://hg.mozilla.org/mozilla-central/rev/fc6e3f356b0d
https://hg.mozilla.org/mozilla-central/rev/2f88dd16b396
https://hg.mozilla.org/mozilla-central/rev/b6f193afd449
https://hg.mozilla.org/mozilla-central/rev/6da46fc6472c

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d776a0e1331
Unifdef ImageDocument's resolution logic. r=botond

Comment 14

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/7d776a0e1331