Closed Bug 1631810 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 23141 - css-sizing/percentage-height-in-flexbox.html: start the test with signal window.onload

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23141 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23141
Details from upstream follow.

Carlos Alberto Lopez Perez <clopez@igalia.com> wrote:

css-sizing/percentage-height-in-flexbox.html: start the test with signal window.onload

  • There was a race condition in this test, since the image has to be loaded before the test starts. But before this patch the test was not ensuring this happened and that caused flakiness on WebKit browsers.

  • To fix that we start the test with window.onload signal and we also make the test explicit about when it finish.

Component: web-platform-tests → Layout
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bb4be135eb9
[wpt PR 23141] - css-sizing/percentage-height-in-flexbox.html: start the test with signal window.onload, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/8bb4be135eb9

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.