Add a way to ignore all LSan leaks or disable LSan in a directory
Categories
(Testing :: web-platform-tests, task)
Tracking
(firefox78 fixed)
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: mccr8, Assigned: jgraham)
References
Details
Attachments
(1 file)
The WPT LSan whitelisting mechanism, lsan_allowed, works okay for small leaks, but we have a number of directories that leak a ton of stuff. If somebody renames a function, or the compiler changes and different functions are inlined, then sheriffs and developers have to deal with a failure with a cause that is not obvious.
See, for instance, the discussion in bug 1624185. I've seen this happen over and over again. I've come across two cases where developers working on Fission were confused by this and they just happened to talk about it to me so I was able to diagnose it. Who knows how many developers I don't interact with are struggling with this.
I think what we really need is a way to ignore LSan leaks entirely for a directory. Maybe we could have a special value like "IGNORE_ALL_LEAKS" for lsan_allowed. Ideally, this would make us disable LSan when running in that directory to avoid all of the log spam we get with a leaky directory, but it would be an okay start to just ignore the leaks.
|
Assignee | |
Comment 1•4 years ago
|
||
This adds a new property lsan-disabled to wpt metadata files, which takes
a boolean to determine if lsan should be entirely disabled for that directory.
|
||
Updated•4 years ago
|
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/5fca8d1967ca Allow disabling lsan entirely for directories, r=mccr8,maja_zf
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23433 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Upstream PR merged by moz-wptsync-bot
Description
•