Language selection menulist is not aligned with the "Add" button and with the table, and not the same size
Categories
(Firefox :: Settings UI, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: itiel_yn8)
Details
Attachments
(2 files)
STR:
- Open about:preferences
- Under Language, click "Select"
- Observe the language selection menulist and the followed "Add" button
ER:
Both are not the same size, and are not aligned with each other.
AR:
Same size and alignment.
This is quite easy to fix for the language dialog alone, but it may be better to also unify the min-height for all menulists/buttons/.accessory-button/xul|search-textbox etc. as some of them can appear next to others causing this discernible size difference.
Comment 2•4 years ago
|
||
We should pick either 32px or 30px and fix it at that. I probably didn't improve matters in bug 1616008 when adjusting .accessory-button
but not the others. https://design.firefox.com/photon/components/buttons.html suggests 32px. Looks like bug 1398050 made it 30px for menulists and .accessory-button
buttons in about:preferences . Jared, am I right in thinking we should just be able to settle on 32px given that's what the spec says?
Comment 3•4 years ago
|
||
Yeah, let's go with 32px. Thanks for referencing the spec.
Comment 4•4 years ago
|
||
Itiel has suggested they might be able to work on this. Thanks!
Updated•4 years ago
|
Updated•4 years ago
|
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/53a25bfbffc8 Fix the menulist and "Add" button height and alignment in the language dialog on about:preferences, and unify min-height of some elements to 32px r=Gijs
Comment 7•4 years ago
|
||
bugherder |
Description
•