Closed Bug 1631825 Opened 4 years ago Closed 4 years ago

Language selection menulist is not aligned with the "Add" button and with the table, and not the same size

Categories

(Firefox :: Settings UI, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 78
Tracking Status
firefox78 --- verified

People

(Reporter: itiel_yn8, Assigned: itiel_yn8)

Details

Attachments

(2 files)

STR:

  1. Open about:preferences
  2. Under Language, click "Select"
  3. Observe the language selection menulist and the followed "Add" button

ER:
Both are not the same size, and are not aligned with each other.

AR:
Same size and alignment.

This is quite easy to fix for the language dialog alone, but it may be better to also unify the min-height for all menulists/buttons/.accessory-button/xul|search-textbox etc. as some of them can appear next to others causing this discernible size difference.

Attached image Screenshot
Summary: Language selection menulist is not aligned with the "Add" button, and not the same size → Language selection menulist is not aligned with the "Add" button and with the table, and not the same size

We should pick either 32px or 30px and fix it at that. I probably didn't improve matters in bug 1616008 when adjusting .accessory-button but not the others. https://design.firefox.com/photon/components/buttons.html suggests 32px. Looks like bug 1398050 made it 30px for menulists and .accessory-button buttons in about:preferences . Jared, am I right in thinking we should just be able to settle on 32px given that's what the spec says?

Flags: needinfo?(jaws)
Priority: -- → P3

Yeah, let's go with 32px. Thanks for referencing the spec.

Flags: needinfo?(jaws)

Itiel has suggested they might be able to work on this. Thanks!

Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Flags: needinfo?(itiel_yn8)
Attachment #9143491 - Attachment description: Bug 1631825 - Fix the menulist and "Add" button height and alignment, and unify min-height to some elements to 32px r?gijs → Bug 1631825 - Fix the menulist and "Add" button height and alignment in the language dialog on about:preferences, and unify min-height of some elements to 32px r?gijs
Flags: needinfo?(itiel_yn8)
Severity: -- → S4
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/53a25bfbffc8
Fix the menulist and "Add" button height and alignment in the language dialog on about:preferences, and unify min-height of some elements to 32px r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78

Verified with 81.0 and 78.3.0esr.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: