Closed Bug 1631838 Opened 4 months ago Closed 4 months ago

originalReferrer for a download's referrerInfo can be null in DownloadsManager.jsm

Categories

(Firefox :: New Tab Page, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 77
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Regression)

Details

Attachments

(1 file)

In bug 1576284 we started using the referrer's spec, but we don't check if the URI is null or not, so we throw:

TypeError: download.source.referrerInfo.originalReferrer is null

from https://searchfox.org/mozilla-central/rev/d2cec90777d573585f8477d5170892e5dcdfb0ab/browser/components/newtab/lib/DownloadsManager.jsm#48 .

Seeing this on my daily driver browser. I think it's as a result of opening a pdf in pdfjs and clicking the download button in there to download it.

Priority: -- → P3
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c3d414d2ba54
fix referrer info checks in Activity Stream's DownloadManager, r=gvn
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
Regressions: 1635054
You need to log in before you can comment on or make changes to this bug.