1631961 - [wpt-sync] Sync PR 23154 - [@property] Support unregistering properties

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23154 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23154
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[@property] Support unregistering properties

Having a declarative version of CSS.registerProperty means we must
effectively support unregistering properties as well: after all,
the stylesheet containing the @property can be removed with JS.

This CL implements that by clearing all declared registrations
from the registry when the active stylesheets change.

Bug: 973830, 978780
Change-Id: I5d5688176ecba75354a3b07750ebe47fb9c2949a
Reviewed-on: https://chromium-review.googlesource.com/2159216
WPT-Export-Revision: 6620a6f6975cabb597157c2816a8ca4b708a14c8

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 23154 applied with additional changes from upstream: 7aa1b761a317d924763915d2505f3a500659b47f

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=96853121af321a9e7eaf0d0577180949ccb8ccfb

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 65 tests

Status Summary

Firefox

PASS : 64
ERROR: 1

Chrome

OK : 1
PASS : 2
FAIL : 6

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/determine-registration.html: ERROR (Chrome: OK, Safari: ERROR)

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 65 tests

Status Summary

Firefox

PASS : 64
ERROR: 1

Chrome

OK : 1
PASS : 2
FAIL : 6

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/determine-registration.html: ERROR (Chrome: OK, Safari: ERROR)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10656899d1c3
[wpt PR 23154] - [@property] Support unregistering properties, a=testonly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7741def4c97e
[wpt PR 23154] - [@property] Support unregistering properties, a=testonly

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7741def4c97e