Closed Bug 1631961 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 23154 - [@property] Support unregistering properties

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23154 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23154
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@property] Support unregistering properties

Having a declarative version of CSS.registerProperty means we must
effectively support unregistering properties as well: after all,
the stylesheet containing the @property can be removed with JS.

This CL implements that by clearing all declared registrations
from the registry when the active stylesheets change.

Bug: 973830, 978780
Change-Id: I5d5688176ecba75354a3b07750ebe47fb9c2949a
Reviewed-on: https://chromium-review.googlesource.com/2159216
WPT-Export-Revision: 6620a6f6975cabb597157c2816a8ca4b708a14c8

PR 23154 applied with additional changes from upstream: 7aa1b761a317d924763915d2505f3a500659b47f
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 65 tests

Status Summary

Firefox

PASS : 64
ERROR: 1

Chrome

OK : 1
PASS : 2
FAIL : 6

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/determine-registration.html: ERROR (Chrome: OK, Safari: ERROR)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 65 tests

Status Summary

Firefox

PASS : 64
ERROR: 1

Chrome

OK : 1
PASS : 2
FAIL : 6

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/determine-registration.html: ERROR (Chrome: OK, Safari: ERROR)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10656899d1c3
[wpt PR 23154] - [@property] Support unregistering properties, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/7741def4c97e
[wpt PR 23154] - [@property] Support unregistering properties, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.