Closed Bug 1631998 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 23160 - Floated flex and grid items

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23160 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23160
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

Floated flex and grid items

Floated flex and grid items have their 'float' incorrectly computed to
"none". This change fixes this by adjusting IsFloating() for flex and
grid items inside LayoutBox::UpdateFromStyle() instead of inside
StyleAdjuster::AdjustStyleForDisplay().

Beyond this, legend elements are not allowed to be rendered legends
if they are floating. However, if legends are flex items, we
adjust IsFloating() to be false. This causes legends to be
used as rendered legends when they are flex items, even if they
were styled as a float.

This is fixed by checking ComputedStyle::IsFloating() instead
of LayoutObject::IsFloating() when finding the rendered legend in
order to get its non-adjusted floating value.

Bug: 875235,350505
Change-Id: Ia1e7f7c244cc0c443cd58be42854866884b7f7e7

Reviewed-on: https://chromium-review.googlesource.com/2157889
WPT-Export-Revision: b936cd2570c63b6bc9922391976f2bbc2655d6be

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Component: DOM: Core & HTML → Layout

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

Status Summary

Firefox

OK : 2
PASS: 5

Chrome

OK : 2
FAIL: 5

Safari

OK : 2
FAIL: 5

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88c0485b7dc3
[wpt PR 23160] - Don't reset computed 'float' for flex and grid items, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/640adac9fa56
[wpt PR 23160] - Don't reset computed 'float' for flex and grid items, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.