1632053 - [macOS] Preferences - dark theme separators not cleared after removing focus in preferences dropdown menus

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect, P2)

Description

[Cristian Fogel [:cfogel]]

Attachment: Screen Recording 0002-04-22 at 09.34.32.mov

Affected versions

• 76.0b7, 77.0a1 (2020-04-20)

Affected platforms

• macOS 10.15.3

Steps to reproduce

1. Launch Firefox and access about:preferences#general
2. Click inside the preferences Menu;
3. Click and open the Dropdown menu for Font-picker;
4. Hover up-down inside the menu;

Expected result

• effects properly applied/cleared;

Actual result

• hovering away from menu options does not clear the blue line;

Regression range

• Last good: 2019-06-05;
• First bad: 2019-06-06;
• Pushlog URL;

Additional notes

• the issue might not always trigger
• attached screen recording with the issues.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I can only reproduce this on a Retina display. I suspect maybe there's a rounding issue somewhere when invalidating?

I suspect this is actually a painting / invalidating issue.

Comment 2

[Kris Taeleman (:ktaeleman)]

@Cristian: Would it be possible to attach your about:support?

Comment 3

[Cristian Fogel [:cfogel]]

Attachment: Application Basics

Sure.

Comment 4

[Kris Taeleman (:ktaeleman)]

Hey Cristian,

Could you try to enable webrender and see if the issue occurs there as well?
about:config -> gfx.webrender.all true

Thanks!

Comment 5

[Cristian Fogel [:cfogel]]

Sure, same issue with the pref on true.
Now, as another note is that the issue still doesn't trigger 100%, just noticed it that it got triggered in another menu (Homepage and new windows one) but it did not reproduce with the one reported in the initial report. Confirmed this with a fresh profile as well.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jbonisteel, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 7

[Darkspirit]

(In reply to Cristian Fogel [:cfogel] from comment #0)
Does this bug still occur?

Comment 8

[Gregory Pappas [:gregp]]

comment 7

Comment 9

[Cristian Fogel [:cfogel]]

Attachment: 111.png

Looking at 113.0a1 (2023-04-07); issue no longer manifests.

Comment 10

[Cristian Fogel [:cfogel]]

113.0a1 (2023-04-07)