1632102 - Links appear in plain text color

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[erfiaschi]

Attachment: youtube.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

I set custom background and text colors (but it's the same with default colors) and opened youtube.
It happens on different sites, too.

Actual results:

Links are the color of plain text.

Expected results:

Links should have been recognizable in their own links color.

Comment 1

[Andre Klapper]

Please provide exact and clear steps to reproduce which allow someone else to reproduce the same situation, without having to guess or interpret anything. Thanks!

Comment 2

[erfiaschi]

I apologize for the inconvenience. I thought it was clear but, clearly, I was wrong.
Here are the steps.

1. Open menu and click Options
2. scroll until colors and click on button
3. set custom colors (yellow for text, red for links)
4. uncheck "use system colors"
5. select always in override mode
6. enter http://www.youtube.com in address bar and click enter
7. links display in yellow instead of red.

This is an example as it happens with different colors and different sites. Specific for version 75.
I hope I helped to make things clearer.
Thank you very much for your precious and very appreciated work.

Comment 3

[Andrei Purice]

Hello there erfiaschi,

I was able to repro this using your steps on the Nightly 77.0a1 (2020-04-29), beta 76.0 and release 75.0 versions. Indeed it does take the yellow color for links on descriptions on youtube (checked with other sites like cnn.com, foxnews.com and it occurs for some links as well, but a minor percentage than youtube).

Adding a component for this issue in order to get the dev team involved.
If it's not the correct one please feel free to reassign a more appropriate one.

Comment 4

[erfiaschi]

Thank you very much. I'm glad I've been useful to you, but I'll never be thankful enough for your outstanding work.
I hope you'll sort this bug out easily, as I can confirm it happens on many many different sites.
Hugs to you and all the team!

Comment 5

[Jonathan Kew [:jfkthame]]

This seems like a styling issue rather than Layout:Text; moving to CSS Parsing & Computation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

So this is the most reduced test-case: data:text/html,<a href="somewhere"><span style="color: green">Should be... red maybe?</span></a>

Basically those links have nested elements overriding colors. I think right now we override the color: green with the text color, and that's why it ends up looking like text.

I think we should treat it as revert instead, but that's a bit tricky with the special handling we do for color: transparent...

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1632102 - Only override to default color in high-contrast / forced-colors mode if inheriting from transparent. r=morgan,#style

That way elements inside links, form controls, etc have the right
contrast, even if the page overrides the color.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/876524e046ea
Only override to default color in high-contrast / forced-colors mode if inheriting from transparent. r=morgan

Comment 9

[Emilio Cobos Álvarez (:emilio)]

(In reply to Pulsebot from comment #8)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/876524e046ea
Only override to default color in high-contrast / forced-colors mode if
inheriting from transparent. r=morgan

Gah, I just saw it too late, but the commit message is missing a crucial not after if... Oh well :(

The patch does the right thing though ;)

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/876524e046ea