Closed Bug 1632168 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 23167 - [@property] Improve test coverage for valid/invalid rules

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23167 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23167
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@property] Improve test coverage for valid/invalid rules

This adds new tests that verify that invalid rules are ignored,
and don't affect other valid rules.

I also rewrote this test file to use utils.js more liberally. It makes
individual tests harder to understand for the uninitiated, but it
scales so much better as the number of test functions increases.

Bug: 973830
Change-Id: Ie19d85042a0475180cc4bbee4ad202ea08adba73

Reviewed-on: https://chromium-review.googlesource.com/2161005
WPT-Export-Revision: 28f4eb5c44840d16baac85d2b28b1e06fdb568a9

PR 23167 applied with additional changes from upstream: 7aa1b761a317d924763915d2505f3a500659b47f, 8e6a1cd4151d2a3387bfafebd54650c54a890695
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 65 tests

Status Summary

Firefox

OK : 1
PASS : 64
FAIL : 13
ERROR: 1

Chrome

OK : 1
PASS : 2
FAIL : 11

Safari

OK : 1
FAIL : 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/determine-registration.html: ERROR [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], OK [GitHub] (Chrome: OK, Safari: OK)
@property registrations are cleared when rule removed: FAIL (Chrome: FAIL, Safari: FAIL)
Previous invalid rule does not prevent valid rule from causing registration: FAIL (Chrome: FAIL, Safari: FAIL)
CSS.registerProperty determines the registration when uncontested: FAIL (Chrome: PASS, Safari: FAIL)
@property later in stylesheet wins: FAIL (Chrome: FAIL, Safari: FAIL)
Invalid @property rule (missing syntax) does not overwrite previous valid rule: FAIL (Chrome: FAIL, Safari: FAIL)
Invalid @property rule (missing initial-value) does not overwrite previous valid rule: FAIL (Chrome: FAIL, Safari: FAIL)
@property determines the registration when uncontested: FAIL (Chrome: FAIL, Safari: FAIL)
CSS.registerProperty wins over @property: FAIL (Chrome: PASS, Safari: FAIL)
Computed value becomes token sequence when @property is removed: FAIL (Chrome: FAIL, Safari: FAIL)
Invalid @property rule (missing inherits descriptor) does not overwrite previous valid rule: FAIL (Chrome: FAIL, Safari: FAIL)
@property later in document order wins: FAIL (Chrome: FAIL, Safari: FAIL)
Unknown descriptors are ignored and do not invalidate rule: FAIL (Chrome: FAIL, Safari: FAIL)
Inherited status is reflected in computed styles when @property is removed: FAIL (Chrome: FAIL, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 65 tests

Status Summary

Firefox

OK : 1
PASS : 64
FAIL : 13
ERROR: 1

Chrome

OK : 1
PASS : 2
FAIL : 11

Safari

OK : 1
FAIL : 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/determine-registration.html: ERROR [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], OK [GitHub] (Chrome: OK, Safari: OK)
@property registrations are cleared when rule removed: FAIL (Chrome: FAIL, Safari: FAIL)
Previous invalid rule does not prevent valid rule from causing registration: FAIL (Chrome: FAIL, Safari: FAIL)
CSS.registerProperty determines the registration when uncontested: FAIL (Chrome: PASS, Safari: FAIL)
@property later in stylesheet wins: FAIL (Chrome: FAIL, Safari: FAIL)
Invalid @property rule (missing syntax) does not overwrite previous valid rule: FAIL (Chrome: FAIL, Safari: FAIL)
Invalid @property rule (missing initial-value) does not overwrite previous valid rule: FAIL (Chrome: FAIL, Safari: FAIL)
@property determines the registration when uncontested: FAIL (Chrome: FAIL, Safari: FAIL)
CSS.registerProperty wins over @property: FAIL (Chrome: PASS, Safari: FAIL)
Computed value becomes token sequence when @property is removed: FAIL (Chrome: FAIL, Safari: FAIL)
Invalid @property rule (missing inherits descriptor) does not overwrite previous valid rule: FAIL (Chrome: FAIL, Safari: FAIL)
@property later in document order wins: FAIL (Chrome: FAIL, Safari: FAIL)
Unknown descriptors are ignored and do not invalidate rule: FAIL (Chrome: FAIL, Safari: FAIL)
Inherited status is reflected in computed styles when @property is removed: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0ad858be229
[wpt PR 23167] - [@property] Improve test coverage for valid/invalid rules, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/051a318587b2
[wpt PR 23167] - [@property] Improve test coverage for valid/invalid rules, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.