Closed
Bug 163217
Opened 23 years ago
Closed 22 years ago
static builds are busted in uconv
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
People
(Reporter: keeda, Assigned: keeda)
Details
(Keywords: intl)
Attachments
(2 files, 2 obsolete files)
29.50 KB,
patch
|
netscape
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
9.30 KB,
patch
|
alecf
:
superreview+
|
Details | Diff | Splinter Review |
Static build have been busted since bug 157993 got checked in. Thats been
bugging me since I build my own static mozilla on solaris. Filing this bug since
I have patches that un-bust the static build (at least for me). Hope this
doesn't conflict with anything that you are already doing.
As per http://bugzilla.mozilla.org/show_bug.cgi?id=157993#c43
>seawood: yes, before each library had their own unique set of shared classes -
>ucvja had "nsUCvJABasicDecoderSupport", ucvko had "nsUCvKOBasicDecoderSupport"
>and so forth - now they all share the same set of classes, as defined in the
>library intl/uconv/util - ucvmath shares these as well now..
As was pointed out in that bug a bit further down, that is not entirely
accurate. ucvmath seems to have a copy of those classes (it doesn't share them).
And the static build fails since the pairs of classes have the same names.
This could be fixed either by
a) actually making ucvmath share those classes as dbaron suggested. But, there
seem to be a few (minor) differeces in the two copies of those classes, so I
dont know if that directly works or not.
b) or simply renaming one of set of the classes that conflict.
b is completely safe, though much uglier. a is probably the right thing to do,
but probably needs more code-eyeballing and testing than I can do (none).
Both patches coming up. Pick one or none ...
(cc'ed dbaron since he seemed to be interested)
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
code issue, QA to yokoyama@netscape.com for now.
Keywords: intl
QA Contact: ruixu → yokoyama
Comment 4•22 years ago
|
||
the first approach is the correct approach, you just need to do one thing -
remove all the GetMaxLength calls() (both the declaration in the .h file, and
the implementation in the .cpp file) from all the classes.
With that I will review the first approach.
Please dont' take the second approach..
Assignee | ||
Comment 5•22 years ago
|
||
Again ... this is totally untested. Just checked if it compiles. (Infact, I
wouldn't know how to test it :-) )
Attachment #95698 -
Attachment is obsolete: true
Attachment #95699 -
Attachment is obsolete: true
Comment 6•22 years ago
|
||
Comment on attachment 95865 [details] [diff] [review]
If you say so ......
sr=alecf
I tested this on windows - we still need to do the work for mac - I'll attach a
patch for that.
Attachment #95865 -
Flags: superreview+
Redundant effort could have been better coordinated - similar patch was attached
on bug 162918.
... and would have been if bug 162918 were mentioned on bug 157993.
Assignee | ||
Comment 10•22 years ago
|
||
Oh well. Sorry.
Should have looked for a dup before doing this.
What now? Mark this a duplicate of that.
Comment 11•22 years ago
|
||
Comment on attachment 95865 [details] [diff] [review]
If you say so ......
r=cls
Attachment #95865 -
Flags: review+
Comment 12•22 years ago
|
||
*** Bug 162918 has been marked as a duplicate of this bug. ***
Comment 13•22 years ago
|
||
cc'ing brian who might, just MIGHT help us out with the mac :)
All you have to do on the mac is apply this patch, and then go yank
nsUCvMathSupport.cpp from ucvmath.shlb and add the 3 cpp files from ../util
(nsUCConstructors.cpp, nsUCSupport.cpp, and nsUCRegUtils.cpp
Comment 14•22 years ago
|
||
Comment 15•22 years ago
|
||
Comment on attachment 96046 [details] [diff] [review]
Diffs of ucvmath.xml (Mac project file)
sr=alecf
all we need is an r= here and I'll land all of this.
Attachment #96046 -
Flags: superreview+
Comment 16•22 years ago
|
||
bug is fixed. Thanks Harshal for fixing this and thanks bnesse for the mac help.
I'm going to reassign to you since you did the work, then mark it fixed.
Assignee: alecf → keeda
Assignee | ||
Comment 17•22 years ago
|
||
Marking fixed. This was checked in a while back.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•