Closed Bug 1632171 Opened 4 months ago Closed 3 months ago

[wpt-sync] Sync PR 23168 - [@property] Mark for recalc when removing declarations

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23168 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23168
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@property] Mark for recalc when removing declarations

I forgot to notify StyleEngine when the property registry changes
due to declarations being cleared. This meant removals would not
take effect correctly/predictably.

Since CSS.registerProperty / @property use the pattern of static
methods on PropertyRegistration to do some work + notifying
StyleEngine, we can follow the same pattern for this case.

Also rename CustomPropertyRegistered to PropertyRegistryChanged.

Bug: 978780, 973830
Change-Id: I3bd03f548a7783f1270d823501e4bf9b1c0778e6
Reviewed-on: https://chromium-review.googlesource.com/2160925
WPT-Export-Revision: be92a251fa4dc75cd6301a72cfa118287ee41c80

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 65 tests

Status Summary

Firefox

OK : 1
PASS: 64
FAIL: 5

Chrome

OK : 1
FAIL: 5

Safari

OK : 1
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/at-property-stylesheets.html
@property removal detected with removal of first stylesheet: FAIL (Chrome: FAIL, Safari: FAIL)
@property removal detected when last @property rule disappears: FAIL (Chrome: FAIL, Safari: FAIL)
@property detected when stylesheet appears: FAIL (Chrome: FAIL, Safari: FAIL)
@property removal detected with removal of second stylesheet: FAIL (Chrome: FAIL, Safari: FAIL)
@property detected in second stylesheet: FAIL (Chrome: FAIL, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 65 tests

Status Summary

Firefox

OK : 1
PASS: 64
FAIL: 5

Chrome

OK : 1
FAIL: 5

Safari

OK : 1
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/at-property-stylesheets.html
@property removal detected with removal of first stylesheet: FAIL (Chrome: FAIL, Safari: FAIL)
@property removal detected when last @property rule disappears: FAIL (Chrome: FAIL, Safari: FAIL)
@property detected when stylesheet appears: FAIL (Chrome: FAIL, Safari: FAIL)
@property removal detected with removal of second stylesheet: FAIL (Chrome: FAIL, Safari: FAIL)
@property detected in second stylesheet: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9eaceb35934a
[wpt PR 23168] - [@property] Mark for recalc when removing declarations, a=testonly
https://hg.mozilla.org/integration/autoland/rev/74704c4f3d2d
[wpt PR 23168] - Update wpt metadata, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/d3849d6b9c2a
[wpt PR 23168] - [@property] Mark for recalc when removing declarations, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ce9b1e876bbd
[wpt PR 23168] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.