1632180 - Make webrender CI on github pass again

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

Bug 1604615 accidentally caused the linux CI jobs for webrender on github to start failing. See e.g. https://github.com/servo/webrender/pull/3928#issuecomment-617468629

The reason is that there is now a dependency on clang which isn't satisfied by the docker image that the tests run in. I have patches that make this work.

I am, however, seeing some intermittent failure with bindgen (via clang-sys) trying to run llvm-config and failing, even though it's on the $PATH. A sample of this error can be found here although I don't know how long that log will be kept. The relevant snippet is:

cargo:warning=couldn't execute `llvm-config --prefix` (error: No such file or directory (os error 2))
cargo:warning=set the LLVM_CONFIG_PATH environment variable to the full path to a valid `llvm-config` executable (including the executable itself)

which is coming from the clang-sys code here.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1632180 - Update docker image and environment used for WebRender CI on Github to include clang. r?jnicol

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad803728f512
Update docker image and environment used for WebRender CI on Github to include clang. r=jnicol

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ad803728f512

Comment 4

[Marian Raiciof [:marauder]]

== Change summary for alert #25686 (as of Thu, 23 Apr 2020 09:34:20 GMT) ==

Improvements:

33% build times android-5-0-aarch64 opt taskcluster-c5d.4xlarge 1,084.03 -> 728.63
31% build times android-5-0-aarch64 opt taskcluster-c5d.4xlarge 1,089.29 -> 749.49

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25686

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(In reply to Marian Raiciof [:marauder] from comment #4)

== Change summary for alert #25686 (as of Thu, 23 Apr 2020 09:34:20 GMT) ==

Improvements:

33% build times android-5-0-aarch64 opt taskcluster-c5d.4xlarge 1,084.03 -> 728.63
31% build times android-5-0-aarch64 opt taskcluster-c5d.4xlarge 1,089.29 -> 749.49

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25686

This patch wouldn't have caused this. Looking at the graph the data looks very noisy and it's not clear that there is an improvement at all. If anything it went from "less noise" to "more noise".