1632203 - Installer progress bar is not visible with high contrast mode enabled

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P2)

Description

[Daniel Cicas [:dcicas], Release QA]

Attachment: no progress bar high contrast.gif

Note

• note1

Affected versions

• Fx 77.0a1

Affected platforms

• Win 10

Steps to reproduce

1. Activate high contrast mode.
2. Download and run the stub installer.

Expected result

• The progress bar is visible.

Actual result

• The progress bar is invisible.

Regression range
Fx 77.0a1 (build ID 2020-04-21-09-42-20)

Comment 1

[Adam Gashlin (he/him) [:agashlin]]

It looks like the method we're using to display the progress bar, which relies on contrasting background-colors, is not going to work with high contrast, which overrides colors. I'll look into alternatives.

Comment 2

[Adam Gashlin (he/him) [:agashlin]]

Attachment: Bug 1632203 - Show legible progress bar in high contrast mode. r?mhowell

These styles will produce no change in the layout, and only apply in
high contrast mode.
Also removed an extra comma that broke parsing in aurora.

Comment 3

[Adam Gashlin (he/him) [:agashlin]]

Attachment: Proposed fix using outline and border

Here's what the patch looks like. There is a little artifact due to Windows blitting the outline and border both with XOR, so when they overlap the color switches back, and there are little single-pixel lines of this due to my high DPI display, but I think it is acceptably legible.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/954ee70d2de7
Show legible progress bar in high contrast mode. r=mhowell

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/954ee70d2de7

Comment 6

[Cristian Baica [:cbaica], Release Desktop QA]

Tested on the latest Fx77.0a1 on Windows 10.
The install bar is now visible while using the high contrast theme, both black and white options. The issue is verified fixed.