Closed Bug 1632230 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 23175 - Sort CSS computed style properties in lexicographical order, again

Categories

(Core :: DOM: CSS Object Model, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23175 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23175
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

Sort CSS computed style properties in lexicographical order, again

This is a follow-up of r760732, where I included logical properties when
iterating a computed style declaration. The problem was that I inserted
some of them at the wrong position, breaking the lexicographical order
achieved in r760690.

This time I add a test that checks that the order is right.

BUG=1072722,1072180

TEST=external/wpt/css/cssom/cssstyledeclaration-csstext.html
TEST=external/wpt/css/cssom/getComputedStyle-property-order.html

Change-Id: I3ea31024deed8b5a4c67a5a117c358cab6c9d7d4
Reviewed-on: https://chromium-review.googlesource.com/2160913
WPT-Export-Revision: 35b61c049c4c14624afe5da30ff6f61e9a44fa79

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 65 tests

Status Summary

Firefox

OK : 1
PASS: 1[GitHub] 65[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22b4c441833a
[wpt PR 23175] - Sort CSS computed style properties in lexicographical order, again, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/c5443e2f9b7c
[wpt PR 23175] - Sort CSS computed style properties in lexicographical order, again, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.