Closed Bug 1632231 Opened 4 months ago Closed 4 months ago

Let ContentBlockingController fail gracefully when trying to add/remove/check an invalid exception

Categories

(GeckoView :: Tracking Protection, defect, P1)

All
Android

Tracking

(firefox77 fixed)

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: droeh, Assigned: droeh)

Details

(Whiteboard: [geckoview:m77])

Attachments

(1 file)

We should use ContentBlockingAllowList.canHandle to validate input to ContentBlockingController.add/remove/checkException and fail gracefully when it's invalid; failing to do this was causing a pretty terrible crash on fxr for me.

Priority: -- → P1
Whiteboard: [geckoview:m77]
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea0374547549
Fix potential crash by gracefully failing when GV tries to add/remove/check content blocking exceptions for invalid URIs. r=esawin
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.