Closed Bug 1632231 Opened 4 years ago Closed 4 years ago

Let ContentBlockingController fail gracefully when trying to add/remove/check an invalid exception

Categories

(GeckoView :: General, defect, P1)

Product:
GeckoView
Component:
General
Platform:
All
Android
Type:
defect

Tracking

(firefox77 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: droeh, Assigned: droeh)

Details

(Whiteboard: [geckoview:m77])

Attachments

(1 file)

Bug 1632231 - Fix potential crash by gracefully failing when GV tries to add/remove/check content blocking exceptions for invalid URIs. r=esawin!
47 bytes, text/x-phabricator-request
Details | Review

We should use ContentBlockingAllowList.canHandle to validate input to ContentBlockingController.add/remove/checkException and fail gracefully when it's invalid; failing to do this was causing a pretty terrible crash on fxr for me.

Priority: -- → P1
Whiteboard: [geckoview:m77]
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea0374547549
Fix potential crash by gracefully failing when GV tries to add/remove/check content blocking exceptions for invalid URIs. r=esawin

https://hg.mozilla.org/mozilla-central/rev/ea0374547549

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

Move GeckoView::Tracking Protection bugs to the GeckoView::General component.

Component: Tracking Protection → General
You need to log in before you can comment on or make changes to this bug.