Closed Bug 1632332 Opened 4 months ago Closed 4 months ago

Improve inner-window-nuked handling for browser_windowProxy_transplant.js

Categories

(Core :: XPConnect, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

kmag pointed out that a window should unregister itself after it gets the inner-window-nuked notification. It also should check that the notification is actually for the current window and not some other random window. Hopefully this will paper over the intermittent failures in this test that we are seeing.

I filed bug 1632338 about trying to fix the underlying wrapping issue.

See Also: → 1632338

I think when I was writing this code I was thinking of "inner-window-nuked" like it was an event that would be specific to this particular window and not just this thing in a global "namespace".

This code is supposed to test what happens when you wrap the outer for an
inner after the inner has been nuked, and the outer has navigated to a
remote window. However, the current code just runs when any window anywhere
gets nuked. Also, it never unregisters itself. This patch fixes both of
those issues.

My hope is that this will fix an intermittent orange we are seeing, but
there's also an underlying issue that should be addressed at some point.

Assignee: nobody → continuation
Status: NEW → ASSIGNED
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0826f9b47188
Improve inner-window-nuked handling in browser_windowProxy_transplant.js. r=kmag

P2

Severity: -- → normal
Priority: -- → P2
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.