Open Bug 1632394 Opened 1 year ago Updated 1 year ago

Saved logins lack hover on focus effects when trying to pick on desired page with a dark theme

Categories

(Toolkit :: Password Manager, defect, P3)

Product:
Toolkit
Component:
Password Manager
Type:
defect

Tracking

()

Status:
ASSIGNED
Tracking Flags:
Tracking Status
firefox-esr68 --- wontfix
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- affected

People

(Reporter: cfogel, Assigned: f94olivera)

Details

(Whiteboard: [passwords:fill-ui])

Attachments

(2 files)

Screenshot 0002-04-23 at 08.44.22.png
82.56 KB, image/png
Details
Bug 1632394 - Added :hover to the saved logins. r?MattN
47 bytes, text/x-phabricator-request
Details | Review

Affected versions

  • 75.0, 76.0b7, 77.0a1 (2020-04-21);

Affected platforms

  • macOS 10.15.3, Windows 10, Ubuntu 18.04;

Steps to reproduce

  1. Launch Firefox, save/set up at least 2 accounts for any webpage;
  2. Access that webpage, click to open the saved login options;
  3. Hover over the logins;

Expected result

  • hover effect applied over the on-hover element;

Actual result

  • login data not marked as hovered over, as per Saved Logins button;

Regression range

  • First bad: 2019-07-18;
  • Last good: 2019-07-17;
  • Pushlog: URL
  • not a regression, with introduction of the new about:logins page; checked after that and considered builds prior to it as good. With introduction of it, the hover was not implemented on it at all.

Additional notes

  • attaching screenshot with the "affected area".
status-firefox75: affected → wontfix
status-firefox76: affected → wontfix
status-firefox-esr68: --- → wontfix
Flags: qe-verify+
Priority: -- → P3
Whiteboard: [passwords:fill-ui]

Is this with the default theme or a dark theme? It sounds like this is specific to dark mode.

Summary: Saved logins lack hover on focus effects when trying to pick on desired page → Saved logins lack hover on focus effects when trying to pick on desired page with a dark theme

Indeed, the hover effect appears on the Light Theme setup.

Component: about:logins → Password Manager
Product: Firefox → Toolkit

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Severity: normal → S3

Hey Matt, It's me again, could I be assigned for this one as well?

Flags: needinfo?(MattN+bmo)

Depends on D76468

Assignee: nobody → f94olivera
Status: NEW → ASSIGNED

I think I messed up, need your help please... this commit bug fix does NOT depend on D76468, tried to solve it myself but i couldn't

Flags: needinfo?(MattN+bmo)

(In reply to f94olivera from comment #4)

Hey Matt, It's me again, could I be assigned for this one as well?

Attaching a patch assigns you automatically

(In reply to f94olivera from comment #6)

I think I messed up, need your help please... this commit bug fix does NOT depend on D76468, tried to solve it myself but i couldn't

Fixed.

I commented on the bug that I'm not sure this is the right solution as it also changes outside of the dark theme but doesn't cleanup the existing styles.

You need to log in before you can comment on or make changes to this bug.