1632448 - Remove window.external.AddSearchProvider code

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Following on from bug 1632447, this bug will remove the preference and all code associated with AddSearchProvider, save for the dummy-function.

Comment 1

[Mark Banner (:standard8)]

Moving out to 80.1 as this will be easier to do alongside the rest of the clean-up we'll be doing (bug 1619926 & others).

Comment 2

[Mark Banner (:standard8)]

Note to self: When we do this, we can also remove the confirm parameter of nsISearchEngine:addEngine and remove the associated confirm code.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1632448 - Remove AddSearchProvider implementation. r?baku!,daleharvey!

Depends on D82350

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1632448 - Remove now unused confirm and extensionID parameters for nsISearchService.addEngine, and rename it. r?daleharvey!

Renaming to addOpenSearchEngine to make it more explicit about what it is actually doing.

Depends on D82524

Comment 5

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=798c27cb63d4d732ef7f6afbebeda6502fa0e637&selectedTaskRun=RppaVBHDS9ShVIrxx_-ZHA.0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/057dda3a3c44
Remove AddSearchProvider implementation. r=baku,daleharvey
https://hg.mozilla.org/integration/autoland/rev/1e758dd2af5f
Remove now unused confirm and extensionID parameters for nsISearchService.addEngine, and rename it. r=daleharvey

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/057dda3a3c44
https://hg.mozilla.org/mozilla-central/rev/1e758dd2af5f