Closed Bug 1632471 Opened 3 years ago Closed 3 years ago

Split out search engine cache handling into a separate object

Categories

(Firefox :: Search, task, P3)

Product:
Firefox
Component:
Search
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 79
Iteration:
79.2 - June 15 - June 28
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(3 files)

Bug 1632471 - Split out search engine cache handling into a separate object. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1632471 - Improve handling of the hash attribute names for the search cache. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1632471 - The SearchEngine object should control what is saved in the cache. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review

Currently the search engine cache handling is intertwined within the main SearchService. To make it easier to handle, and do improvements to the cache part, it would be better if that was a separate object.

Severity: -- → S3

To expand on comment 0, I think the new cache object should handle:

  • Reading/writing of the cache.
  • Handling the delayed write to the cache.
  • Handling of values for the verified attributes (handling the hash, returning the correct value if the hash is verified or not etc).

Side note: what gets saved for the engine data should probably be moved into the SearchEngine object.

Points: --- → 3
Assignee: nobody → standard8
Iteration: --- → 79.1 - June 1 - June 14

As the engine data for the cache is coming from the SearchEngine, it makes more sense that the SearchEngine object looks after the exact data to save.

Depends on D79063

Iteration: 79.1 - June 1 - June 14 → 79.2 - June 15 - June 28
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9f5e1399689
Split out search engine cache handling into a separate object. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/cf14241f9e5b
Improve handling of the hash attribute names for the search cache. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/d0b5b7fc8cee
The SearchEngine object should control what is saved in the cache. r=daleharvey

https://hg.mozilla.org/mozilla-central/rev/b9f5e1399689
https://hg.mozilla.org/mozilla-central/rev/cf14241f9e5b
https://hg.mozilla.org/mozilla-central/rev/d0b5b7fc8cee

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
Regressions: 1647256
You need to log in before you can comment on or make changes to this bug.