Closed Bug 1632515 Opened 5 months ago Closed 5 months ago

Unify the composer format buttons

Categories

(Thunderbird :: Theme, task)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 77.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

It bugged me a long time that osx has two sets of smilies which are more or less identical. Only the size was different to not get dupes on packaging.

I started with the smiley menu and then decided later to unify all format icons.

On Mac, the format button icons are taller than before, 16px instead of 12px, but the buttons have still the same height. What do you think, does this still work?

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9142725 - Flags: review?(alessandro)
Attached image format-buttons-Mac.png

Screenshot of the Mac buttons.

Comment on attachment 9142725 [details] [diff] [review]
1632515-unify-format-buttons.patch

Review of attachment 9142725 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/themes/shared/mail/messengercompose.css
@@ +57,5 @@
>    margin-top: -1px;
>    padding: 2px 0;
> +  background: var(--arrowpanel-background);
> +  color: var(--arrowpanel-color);
> +  border-color: var(--arrowpanel-border-color);

Uh, I see this slipped in (also for #msgIdentityPopup below). The actual colours aren't optimal with the dark theme because no differentiation is visible between popup and the background.

When it's okay for you, I leave it in this patch.

Now with the same button/menulist appearance as Linux and Windows.

Attachment #9142725 - Attachment is obsolete: true
Attachment #9142725 - Flags: review?(alessandro)
Attachment #9142825 - Flags: review?(alessandro)
Comment on attachment 9142825 [details] [diff] [review]
1632515-unify-format-buttons.patch

Review of attachment 9142825 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks good with our button style.
r+
Attachment #9142825 - Flags: review?(alessandro) → review+
Target Milestone: --- → Thunderbird 77.0

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/534231abf4b4
Unify the composer format buttons. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.