1632519 - [GNOME 3.36][WAYLAND][REGRESSION] Clicking bookmarks folders lags the Search, tabs and bookmarks UI

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Marko]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

Open bookmarks folder from the top bookmark bar or in fact any UI element that involves a list of elements, like selecting Version of firefox on Bugzilla or Component on Wayland backend it lags the pop-up element and you can't scroll through it or select elements. Started happening 1-2 days ago with nightly update on Gnome 3.36 and wayland backend.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Can you please try to use mozregression (https://mozilla.github.io/mozregression/) to find a potential regression range?
Thanks.

Comment 2

[Darkspirit]

$ pip install --user --upgrade mozregression
$ GDK_BACKEND=wayland mozregression --good 2020-04-17 --bad 2020-04-23

Comment 3

[Marko]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #2)

$ pip install --user --upgrade mozregression
$ GDK_BACKEND=wayland mozregression --good 2020-04-17 --bad 2020-04-23

Apparently Ubuntu 20.04 dropped python 2, if I try to install mozregression with pip3 it for some reason doesn't want to launch, says
mozregression: command not found

Comment 4

[Darkspirit]

$ pip3 uninstall mozregression
Found existing installation: mozregression 4.0.3
Uninstalling mozregression-4.0.3:
Would remove:
/home/darkspirit/.local/bin/mozregression
/home/darkspirit/.local/lib/python3.8/site-packages/mozregression-4.0.3.dist-info/*
/home/darkspirit/.local/lib/python3.8/site-packages/mozregression/*
Proceed (y/n)? n

Try $ GDK_BACKEND=wayland ~/.local/bin/mozregression --good 2020-04-17 --bad 2020-04-23

Comment 5

[Darkspirit]

This could be bug 1632399.

Comment 6

[Marko]

Here is the output of mozregression:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=145183f126ca2c2fc9c0e9bdd52cbf64219895b7&tochange=d412b7923e10c76202b356c063bd1ef43683534b

Comment 7

[Darkspirit]

Thanks!

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Marko, can you try to set widget.wayland_vsync.enabled to false at about:config and try again?
Thanks.

Comment 9

[Marko]

(In reply to Martin Stránský [:stransky] from comment #8)

Marko, can you try to set widget.wayland_vsync.enabled to false at about:config and try again?
Thanks.

Yes, that workaround solves it indeed :)

Comment 10

[Martin Stránský [:stransky] (ni? me)]

(In reply to Marko from comment #9)

(In reply to Martin Stránský [:stransky] from comment #8)

Marko, can you try to set widget.wayland_vsync.enabled to false at about:config and try again?
Thanks.

Yes, that workaround solves it indeed :)

Marko, which desktop environment / wayland compositor do you run?
Thanks.

Comment 11

[Marko]

(In reply to Martin Stránský [:stransky] from comment #10)

(In reply to Marko from comment #9)

(In reply to Martin Stránský [:stransky] from comment #8)

Marko, can you try to set widget.wayland_vsync.enabled to false at about:config and try again?
Thanks.

Yes, that workaround solves it indeed :)

Marko, which desktop environment / wayland compositor do you run?
Thanks.

I'm using Gnome 3.36.1 and mutter 3.36.1 (Pop!_OS 20.04 Beta)

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Let's revert Bug 1629140 as mutter is not ready yet or Firefox needs some fixes.

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1632519 [Wayland] Turn off widget.wayland_vsync.enabled by default, r?jhorak

Comment 14

[Robert Mader [:rmader]]

Note that at least bug 1619246 (which looks quite similar) can be reproduced on Weston. So before we give this another go we most likely need to fix something in the vsync source - good to have some issues with STRs now :)

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce74b3742209
[Wayland] Turn off widget.wayland_vsync.enabled by default, r=jhorak

Comment 16

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/ce74b3742209