1632577 - Maybe Glean's UUID metric type shouldn't be a c0ffee maker

Status: RESOLVED INVALID

(Data Platform and Tools :: Glean: SDK, enhancement, P4)

Description

[Chris H-C :chutten]

It occurred to me that UUID's generateAndSet could generate the canary client id (the c0ffee one) which would cause all sorts of unintended operation. Maybe we should prevent that?

Or, more narrowly, maybe we should at least guard against accidentally assigning a client_id to the canary value when we don't intend to.

Comment 1

[Alessio Placitelli [:Dexter]]

(In reply to Chris H-C :chutten from comment #0)

Or, more narrowly, maybe we should at least guard against accidentally assigning a client_id to the canary value when we don't intend to.

I think we should do this within glean_core, without touching the metric type itself. c0ffee... is a valid UUID, I guess.

Comment 2

[Jan-Erik Rediger [:janerik]]

generateAndSet cannot generate the UUID c0ffeec0-ffee-c0ff-eec0-ffeec0ffeec0. We use new_v4 to generate v4 UUIDs (random).
c0ffeec0-ffee-c0ff-eec0-ffeec0ffeec0 is not v4 and thus cannot be the output of random generation.