1632775 - Record GC trigger data per slice rather than per collection

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P1)

Description

[Jon Coppeard (:jonco)]

Currently this is recorded per collection which is confusing and means that we don't see correct trigger amounts in the profiler.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1632775 - Record triggers per slice, not per collection r?sfink

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1632775 - Move nursery-related method definitions to be with other public definitions r?sfink

Depends on D72382

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1632775 - Don't attempt to trigger GC when collecting the nursery at the start of a major GC slice r?sfink

Currently we check heap thresholds after collecting the nursery but then clear majorGCTriggerReason if it was set. This leaves the trigger amounts set in the Statistics object.

Depends on D72383

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7725b8236280
Record triggers per slice, not per collection r=sfink
https://hg.mozilla.org/integration/autoland/rev/08cc79bec365
Move nursery-related method definitions to be with other public definitions r=sfink
https://hg.mozilla.org/integration/autoland/rev/12e3bdca260a
Don't attempt to trigger GC when collecting the nursery at the start of a major GC slice r=sfink

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7725b8236280
https://hg.mozilla.org/mozilla-central/rev/08cc79bec365
https://hg.mozilla.org/mozilla-central/rev/12e3bdca260a