16328 - Too many nsToolkit instances are being created.

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[rpotts (gone)]

Currently, there are too many nsToolkit instances being created.  There should
*only* be one created for each UI thread in the application.

However, they are being created for each window that does not have a parent.
This can be seen on windows by running Spy++ and seeing all of the nsToolkit
windows created for the apprunner...

Comment 1

[rpotts (gone)]

I've checked in the code to fix this, however, I've #ifdef'ed it
USE_TLS_FOR_TOOLKIT until the other platforms can be tested...

Currently, the define is enabled *only* for Windows.

Patrick, I'm pushing this bug over to you so you can test the changes on the
Mac.

Once you've turned it on for the Mac, just kick it over to a Unix expert to test
on GTK...

-- rick

Comment 2

[Patrick C. Beard]

I have a fix for this in my tree, at least for the Mac.

Comment 3

[Bruce Mitchener]

Is there any progress on this?  This causes GCs to get leaked on Unix/Gtk.

Comment 4

[Patrick C. Beard]

USE_TLS_FOR_TOOLKIT is now defined in mozilla/widget/macbuild/Widget.prefix
mozilla/widget/macbuild/WidgetDebug.prefix, so that only thread local toolkits 
are being created on the Mac. Reassigning to a UNIX person.

Comment 5

[Stuart Parmenter]

I have had this on in my tree for months.  This should reduce the number of
instances of nsToolkit we are creating reducing the time we spend mallocing,
etc.

Comment 6

[Peter Trudelle]

nsbeta3+ for footprint.

Comment 7

[Stuart Parmenter]

Attachment: patch to fix

Comment 8

[Stuart Parmenter]

one line makefile change to fix bug.  could someone please review?  only effects
linux.  the code is already in use on windows (and I think mac) and I've had it
on in my tree for a long time.

Comment 9

[cls]

That should be DEFINES += -DUSE_TLS_FOR_TOOLKIT

Comment 10

[Stuart Parmenter]

fine, r=cls?

Comment 11

[cls]

r=cls

Comment 12

[Stuart Parmenter]

fixed

Comment 13

[Claudius Gayle]

just marking VERIFIED