Closed
Bug 1632817
Opened 6 years ago
Closed 6 years ago
openpgp key management dialog menu is invisible on ubuntu
Categories
(MailNews Core :: Security: OpenPGP, defect)
MailNews Core
Security: OpenPGP
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 77.0
People
(Reporter: mkmelin, Assigned: mkmelin)
Details
Attachments
(1 file)
|
2.68 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
The menu of the OpenPGP Key Management dialog is invisible. The menubar is by default light and needs to be on a toolbar to get proper dark background and thus showing
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9143061 -
Flags: review?(richard.marti)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9143061 [details] [diff] [review]
bug1632817_pgp_keyman_hidden.patch
Better this way. Bonus points when you indent the whole <menubar> part properly.
The dialog looks a bit weird without a bit padding and I've seen that the close menuitem (the last one in File menu) has no label and doesn't work. On Windows it has the full menuitem height, on Linux only some pixels.
Attachment #9143061 -
Flags: review?(richard.marti) → review+
|
||
Comment 3•6 years ago
|
||
great, thanks for fixing.
I've tested it, too, and it works for me.
Keywords: checkin-needed-tb
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/274dd8d1e772
openpgp key management dialog menu is invisible on ubuntu - needs to be on a toolbar to get proper bg color. r=Paenglab DONTBUILD
|
|
Assignee | |
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 77.0
You need to log in
before you can comment on or make changes to this bug.
Description
•