Closed Bug 1632820 Opened 4 years ago Closed 4 years ago

Only emit bailAfter instrumentation when the testing function is used

Categories

(Core :: JavaScript Engine: JIT, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(1 file)

These debug checks make it a pain to read machine code generated by Ion in debug builds.

It's nicer to not emit this until bailAfter is called for the first time, at that point we can release JIT code to force a recompile with the instrumentation on.

This mechanism added a lot of machine code to Ion JIT code, making it hard to analyze
codegen. With this change we only emit this when necessary.

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3762f151cab2
Only emit bailAfter instrumentation in debug builds when the testing function is used. r=tcampbell
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: