Closed Bug 1632878 Opened 3 months ago Closed 3 months ago

Use the photon junk icon in the notification bar and thread pane

Categories

(Thunderbird :: Theme, task)

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 77.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

We still use a lo-res icon for the junk notification bar also on HiDPI screens. We have a junk.svg we could use.

I took your junk icon from bug 1532378 and modified it to have it filled on the thread pane when marked as junk. What do you think about the colours the junk icon has?

On the notification bar, the icon isn't filled (also in the folder pane with your patch).

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9143112 - Flags: review?(alessandro)
Comment on attachment 9143112 [details] [diff] [review]
1632878-photon-junk-icon.patch

Review of attachment 9143112 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely!
I really like the colours for the active status.

The only issue I'm seeing is a bit of a flash/jump colouring when marking a message as junk.
I don't know if this issue is related to this patch, but it doesn't happen with the PNG.
I wonder if the PNG was slower to load and we never noticed this glitch when the junk flag changes.

See if you can figure out why is happening, but if it's unrelated to these changes, let's open a follow up bug to fix it.
r+
Attachment #9143112 - Flags: review?(alessandro) → review+

Looked with Alessandro. It seems it happens only on one of his accounts. I tried it with different accounts and on all platforms and don't see this issue.

Target Milestone: --- → Thunderbird 77.0

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1d045109e1a3
Use the photon junk icon in the notification bar and thread pane. r=aleca DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.