Closed
Bug 1632939
Opened 4 years ago
Closed 4 years ago
Remove result from infallible txList::add
Categories
(Core :: XSLT, task)
Core
XSLT
Tracking
()
RESOLVED
FIXED
mozilla77
Tracking | Status | |
---|---|---|
firefox77 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(2 files)
txList::add
is actually infallible, but we check it's return code throughout the xslt codebase. We can simplify things by just having it return void. This will make some other cleanups a bit easier.
Assignee | ||
Comment 1•4 years ago
|
||
txList::add
always returns true, we can remove various result checks and simplify things for further refactoring.
Updated•4 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•4 years ago
|
||
Pushed by erahm@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a5d833f0259 Part 1: Get rid of result from infallible txList::add. r=peterv https://hg.mozilla.org/integration/autoland/rev/2847d9f4de20 Part 2: Get rid of result from infallible txStylesheetCompilerState::addInstruction. r=peterv
Comment 4•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0a5d833f0259
https://hg.mozilla.org/mozilla-central/rev/2847d9f4de20
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox77:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in
before you can comment on or make changes to this bug.
Description
•